Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo/ionic #46

Merged
merged 6 commits into from
Sep 8, 2021
Merged

Demo/ionic #46

merged 6 commits into from
Sep 8, 2021

Conversation

sultanmyrza
Copy link
Contributor

@sultanmyrza sultanmyrza commented Sep 4, 2021

Add GoPro Demo project (ionic framework + capacitor 3)

Works for both iOS and Android
✅ . Connect phone to GoPro via bluetooth
✅ . Send Bluetooth Commands (take photo, get wifi creds, shut down)
✅ . Connect phone to GoPro via WiFi
✅ . Download files to phone from GoPro via WiFi

@tcamise-gpsw here is the quick demo for ios and android

🤙 Thank you!

@sultanmyrza
Copy link
Contributor Author

@tcheema-gpsw what have no idea what Pre Merge Checks / copyright (pull_request) it means?

@tcamise-gpsw
Copy link
Collaborator

Yeah something is wrong with the pre-merge checks. I'm looking into it now.

@tcamise-gpsw
Copy link
Collaborator

You probably don't care about this but it turns out I'm running into actions/checkout#455 when accepting pull requests from forks. I worked around it by updating the copyrights on your forked repo.

Copy link
Collaborator

@tcamise-gpsw tcamise-gpsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work here!!! 👏

I have very little experience in any part of this stack but was able to get this working out of the box 👍

FYI I moved it into a new directory (demos/ionic/file_transfer) for consistency with the rest of the demos.

@tcamise-gpsw tcamise-gpsw merged commit 3f87d28 into gopro:main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants