-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: align image tags with GoReleaser artifacts #1841
Conversation
Following the changes introduced in goplus#1838, this commit updates Docker image and manifest tags to align with the GoReleaser artifact naming conventions. The changes are as follows: - Image tags have been updated from "v1.2.3-i386" to "1.2.3-386", from "v1.2.3-x86_64" to "1.2.3-amd64", "v1.2.3-arm64" to "1.2.3-arm64". - The version prefix "v" has been removed from the image manifest tags, changing "v1.2.3" to "1.2.3", "v1.2" to "1.2", and "v1" to "1". Signed-off-by: Aofei Sheng <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1841 +/- ##
=======================================
Coverage 92.63% 92.63%
=======================================
Files 41 41
Lines 11456 11456
=======================================
Hits 10612 10612
Misses 682 682
Partials 162 162 ☔ View full report in Codecov by Sentry. |
I don’t think there’s a right answer to this question, but it’s important not to break previously established conventions. |
The behavior of |
Gop, being a Go project (aka a Go module), requires |
Forgot that. This PR is acceptable. For tagging Docker images, using the version number followed by a suffix without v prefix is more commonly. |
Following the changes introduced in #1838, this commit updates Docker image and manifest tags to align with the GoReleaser artifact naming conventions. The changes are as follows:
Should we keep the
v
prefix? I referred to the tag style ofdocker.io/library/golang
and removed thev
prefix. (See: https://hub.docker.com/_/golang/tags?name=-alpine3.19)/cc @xushiwei @cpunion