Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow setting autosync.interval in minutes #2730

Closed
quite opened this issue Nov 28, 2023 · 3 comments
Closed

Feature: allow setting autosync.interval in minutes #2730

quite opened this issue Nov 28, 2023 · 3 comments

Comments

@quite
Copy link
Contributor

quite commented Nov 28, 2023

It would be useful to be able to set autosync interval with greater granularity. I think minutes could be enough, seconds won't be needed.

To be backwards compatible, we'd move the setting to a string, and still interpret a clean number as days, but accept an m suffix for interpreting the number as minutes.

quite added a commit to quite/fork-gopasspw--gopass that referenced this issue Nov 28, 2023
quite added a commit to quite/fork-gopasspw--gopass that referenced this issue Nov 28, 2023
quite added a commit to quite/fork-gopasspw--gopass that referenced this issue Nov 28, 2023
quite added a commit to quite/fork-gopasspw--gopass that referenced this issue Nov 28, 2023
quite added a commit to quite/fork-gopasspw--gopass that referenced this issue Nov 28, 2023
quite added a commit to quite/fork-gopasspw--gopass that referenced this issue Nov 28, 2023
quite added a commit to quite/fork-gopasspw--gopass that referenced this issue Nov 28, 2023
quite added a commit to quite/fork-gopasspw--gopass that referenced this issue Nov 28, 2023
@AnomalRoil
Copy link
Member

AnomalRoil commented Nov 28, 2023

Autosync isn't run in the background when used in REPL mode, or is it?

Because iiuc it's run before another command if delay has passed, and optionally if set to 0, it's run every time a command is run, no?

So to me, having a granularity below a day is not really better than setting it to 0, no?

Or am I missing a use case?

Edit, sorry I misclicked on Close.

@quite
Copy link
Contributor Author

quite commented Nov 28, 2023

Yes granularity of for example hours (or minutes, for completeness) would be much better than days. Consider that you may be showing/inserting a lot of passwords throughout the day, while (physically) moving between installations of gopass. Having for example 90m would be much better than 0. The former would possible help out greatly with getting things opportunistically synced. The latter would result in tedious sync all the time. And having 1 (day) given this use-case would result in a number of merge conflicts.

quite added a commit to quite/fork-gopasspw--gopass that referenced this issue Nov 29, 2023
dominikschulz pushed a commit that referenced this issue Dec 1, 2023
@AnomalRoil
Copy link
Member

Closed in #2731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants