Add support for refresh_expires_in #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide examples of endpoints that implement that field? I've seen refresh_token_expires_in used by LinkedIn and a few others, but none that use refresh_expires_in. The link provided refers to a configuration file, not the payload returned by the authorization provider. |
|
The most credible looking documentation I could find is https://developer.cisco.com/docs/firepower-device-manager/#!authenticating-your-rest-api-client-using-oauth/requesting-a-custom-access-token I see many results via searching My guess is that since this property isn't part of any standard, it has been copy-pasted in multiple places. |
This is referenced in some OAuth documentation including: * https://developer.cisco.com/docs/firepower-device-manager/#!authenticating-your-rest-api-client-using-oauth/requesting-a-custom-access-token * https://www.ibm.com/docs/en/api-connect/2018.x?topic=settings-configuring-timeouts-access-tokens-refresh-tokens
|
Rebased with master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is referenced in some OAuth documentation including:
This PR doesn't update the dist/* files. This is a proposal at this point and I'd be happy to add changes to the dist file if it's needed.