Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate showcase cleanups #10

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Translate showcase cleanups #10

merged 1 commit into from
Jun 8, 2020

Conversation

calren
Copy link
Collaborator

@calren calren commented Jun 5, 2020 •
edited
Loading

Internal CL: 153272

• Update non-cameraX dependencis
• Replace deprecated use of ViewModelProviders.of() with viewModels()
property delegate
• Remove unnecessary Companion references
• Replace use of this as lifecycle owner with viewLifecycleOwner

@calren
Translate showcase cleanups:
8f8662d 
• Update non-cameraX dependencis
• Replace deprecated use of ViewModelProviders.of() with viewModels()
  property delegate
• Remove unnecessary Companion references
• Replace use of this as lifecycle owner with viewLifecycleOwner
@googlebot googlebot added the cla: yes Contributor License Agreement signed label Jun 5, 2020
@calren calren requested a review from sheepmaster June 6, 2020 15:36
sheepmaster
sheepmaster approved these changes Jun 6, 2020
View reviewed changes
Copy link
Collaborator

@sheepmaster sheepmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Is it okay to add a reference to the internal CL? That might make tracking easier.

@calren
Copy link
Collaborator Author

calren commented Jun 8, 2020

Sure! Added internal cl number in description

@calren calren merged commit 61a4fe7 into master Jun 8, 2020
@calren calren deleted the caren/merge_translate_showcase_improvements branch June 9, 2020 16:53
@sheepmaster sheepmaster added the translate-showcase Translate showcase app label Jul 13, 2020
This was referenced Oct 26, 2021
Closed
Closed
@dunzhixuan dunzhixuan mentioned this pull request Feb 9, 2022
Closed
@dblr4287 dblr4287 mentioned this pull request Mar 17, 2022
Closed
@shanmugpriyan306 shanmugpriyan306 mentioned this pull request Jun 6, 2023
Open
@Saloni1232 Saloni1232 mentioned this pull request Aug 8, 2023
Closed
@Saloni123456 Saloni123456 mentioned this pull request Aug 8, 2023
Open
@guozhuoxing guozhuoxing mentioned this pull request Nov 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheepmaster sheepmaster sheepmaster approved these changes

Assignees
No one assigned
Labels
cla: yes Contributor License Agreement signed translate-showcase Translate showcase app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calren @sheepmaster @googlebot