chore: npm update #812
Merged
chore: npm update #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usefulthink
force-pushed
the
chore/npm-update
branch
7 times, most recently
from
3f8bfb0 to
9fa3d4e
Compare
usefulthink
force-pushed
the
chore/npm-update
branch
from
9fa3d4e to
e428041
Compare
wangela
approved these changes
Feb 15, 2024
usefulthink
added a commit
to usefulthink/js-api-loader
that referenced
this pull request
Feb 16, 2024
in googlemaps#812 the package type was accidentally changed to "module" which leads to all sorts of problems. This is reverted and config-files that are already in esm-format are renamed to .mjs to continue working.
kwnevarez
pushed a commit
that referenced
this pull request
Feb 16, 2024
in #812 the package type was accidentally changed to "module" which leads to all sorts of problems. This is reverted and config-files that are already in esm-format are renamed to .mjs to continue working.
| @@ -33,38 +34,41 @@ | |||
| "test:e2e": "jest e2e/*" | |||
| }, | |||
| "dependencies": { | |||
| "@rollup/plugin-terser": "^0.4.3", | |||
There was a problem hiding this comment.
shouldn't this be a dev dependency?
There was a problem hiding this comment.
It should, thanks for pointing this out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually update all dependencies.