Render only visible items on the map #217

zamesilyasa · 2015-10-19T14:02:26Z

Implemented rendering only visible items on the map(issue #82 )
Added VisibleClusteringDemoActivity activity which demonstrates clustering of 20k items.

…lgorithm. Sow screen size is based on display, but not on map left and right corners coordinates.

…s-utils into issue-82

barbeau · 2015-10-19T14:21:21Z

@broady or @markmcd could you rerun this build on Travis? The initial build failed with com.android.ddmlib.ShellCommandUnresponsiveException, which isn't related to the PR contents.

barbeau · 2015-10-21T02:15:03Z

Thanks, looks like the Travis build passed now. I've been seeing occasional failures due to com.android.ddmlib.ShellCommandUnresponsiveException on Travis builds on other projects too. Increasing the timeout doesn't seem to help, so right now unfortunately the workaround is just to poke Travis again, and it usually passes on the second attempt.

meierjan · 2015-11-11T17:14:03Z

+1 for merge

Dima564 · 2016-01-07T13:29:00Z

+1

broady · 2016-01-11T22:57:27Z

Mark or @jfschmakeit can you look at this more closely?

markmcd · 2016-02-15T06:00:38Z

Awesome - thanks for this contribution. It's looking great on the device. Just a couple of comments around the code.

Oh and I'll re-run the Travis builds when needed, they're very flaky at the moment.

markmcd · 2016-02-15T06:00:47Z

library/src/com/google/maps/android/clustering/ClusterManager.java

        cluster();
    }

+    public void setClusterOnlyVisibleArea(boolean onlyVisibleArea) {


I don't think that a user should have to provide an algorithm as well as specifying this property. Can you refactor such that this property is defined on the Algorithm implementation? e.g. add a method to Algorithm like boolean shouldReclusterOnMapMovement()

What about back compatibility?

If we could use Java 8 we could add a default method to the interface, but alas that's not an option.

How about extending Algorithm (e.g. ViewBasedAlgorithm) and use that to determine instead. You may even be able to move the onCameraChangeListener code in there, too.

I thought about this variant too, but in this case I will have to use instanceof to check, if this algorythm is ViewBasedAlgorithm, but if this algorithm will be decorated(like you do with PreCachingAlgorithmDecorator), it will not work at all. That's why I removed this decoration by default

Ahh, good point. My main concern is that the behaviour of using setClusterOnlyVisibleArea on anything other than the new Algorithm you've introduced is undefined.

The only other option available is to break the Algorithm interface by adding the method suggested above. I've thought about this a bit and I think that it's the right thing to do but I (or whoever releases the next version to Maven) will need to make sure we bump the version number appropriately so it's clear what's happening.

What do you think about that? Reasonable? Or too drastic?

barbeau · 2016-02-15T15:32:20Z

FYI - looks like the Travis timeout issue should hopefully be fixed in 2.0.0-beta3 - see https://code.google.com/p/android/issues/detail?id=189764#c17 for details.

ScreenBasedAlgorithmAdapter is now derived from NonHierarchicalDistanceBasedAlgorithm Added new ScreenBasedAlgorithm interface. Implementing this interface, Algorithm has map position and can skip clustering if it is not required. Removed usage of instanceof checks in ClusterManager, which broke algorithms logic, in case of decorations. googlemaps#82

larten · 2016-03-11T16:15:56Z

I think the getVisibleBounds() method in the VisibleNonHierarchicalDistanceBasedAlgorithm class not working correctly. On bigger screens the bounds not matching to the screen and the displayed area with markers is more bigger. I've tried to fix it with getVisibleRegion() method and calculation, but if user rotate the map, this solution is not working :)
Do you have any idea?

zamesilyasa · 2016-03-11T16:20:55Z

What screen size/dimension do you use?
Also, if you rotate the map, you have to recluster everything.
There is updateViewSize() method in the latest update, call it with the new map size and recluster it.

larten · 2016-03-11T16:38:00Z

I've checked with a 480x800 and a 1920x1080 resolution.

Now, I've solved with this code:

Something wrong with code insertation :(

private Bounds getVisibleBounds(int zoom) {
if (mMapCenter == null) {
return new Bounds(0, 0, 0, 0);
}
Point p = PROJECTION.toPoint(mMapCenter);
Point left = PROJECTION.toPoint(this.left);
Point right = PROJECTION.toPoint(this.right);

    return new Bounds(Math.min(left.x, right.x), Math.max(left.x, right.x),
            Math.min(left.y, right.y), Math.max(left.y, right.y));
}

private LatLng left;
private LatLng right;

@Override
public void onCameraChange(CameraPosition cameraPosition) {
    VisibleRegion visibleRegion = map.getProjection().getVisibleRegion();
    mMapCenter = cameraPosition.target;
    left = visibleRegion.farLeft;
    right = visibleRegion.nearRight;
}

zamesilyasa · 2016-03-11T16:40:04Z

I believe you use too old code. I don't use map bounds anymore. Please, pull the latest version of the patch

larten · 2016-03-11T16:40:32Z

Okey, thank you!

meierjan · 2016-03-29T09:13:06Z

Any idea when this is gonna be merged?

lmbd · 2016-09-01T11:28:30Z

Is it a part of the plan to integrate / merge this functionality?

zamesilyasa · 2016-09-01T11:31:05Z

I am just trying to keep it up to date

lfdversluis · 2016-10-06T08:24:59Z

Is there any reason not to merge this? (besides perhaps squashing commits)

zamesilyasa · 2016-10-06T16:58:14Z

Commits will be squashed by merge, isn't it?

lfdversluis · 2016-10-06T19:58:53Z

Someone with merge rights could, indeed.

If an Algorithm reference is already a ScreenBasedAlgorithm, then it can be passed as is to setAlgorithm(ScreenBasedAlgorithm). Only if it is not already a ScreenBasedAlgorithm is it then wrapped with a ScreenBasedAlgorithmAdapter.

…m-wrap Don't wrap Algorithm if already implements ScreenBasedAlgorithm

googlebot · 2017-02-03T16:55:07Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

jeffdgr8 · 2017-02-13T02:51:27Z

@googlebot I consent to have my commit merged to this project. Looking forward to having this pull request as well as my other two that are pending merged into the base project.

b1n0m13 · 2017-05-05T14:54:55Z

@zamesilyasa I noticed that NonHierarchicalViewBasedAlgorithm.shouldReclusterOnMapMovement() always return true, causing recluster on map movement even if it is just centering at selected cluster.
So when user taps at cluster to see info window it is shown only for a second, then disappear.

zamesilyasa · 2017-06-30T08:25:31Z

@b1n0m13
I had this problem before, but I solved it with custom popup windows. I had a view on top of the map, which showed popup windows. It was not hard to implement, because map is centered after click. So just show a popup at the center of a layout.

always return true

That's the core idea of the algorithm - recluster on map movement.

If you will disable this in case popup is shown and scroll the map, you will see an empty square of the map, what breaks consistency between visual representation and data set

zamesilyasa · 2017-06-30T08:30:14Z

@markmcd
Is there any chance to merge it into dev?

manish-bansal · 2018-04-16T10:08:46Z

Will this be merged with main code?

stephenmcd · 2018-04-17T01:13:37Z

This is merged now, thanks all.

manish-bansal · 2018-04-17T05:57:54Z

Will there be new release with these changes?

manish-bansal · 2018-05-29T09:39:18Z

Is there any plan to release this as part of next release? Managing gradle dependencies are much easier than moving the aar in multiple project.

tmiyamon · 2018-07-20T07:28:07Z

I also want to use this feature in my project with gradle dependencies. Please release it !

lordplagus02 · 2018-12-19T17:09:35Z

+1 Would love this

zamesilyasa added 4 commits January 28, 2015 21:29

Implemented issue googlemaps#82

1cf9f4e

Fixed clustering after map rotation around it's axis

7e91e4f

Fixed screen size computation in VisibleNonHierarchicalDistanceBasedA…

0ce7080

…lgorithm. Sow screen size is based on display, but not on map left and right corners coordinates.

Merge branch 'issue-82' of https://github.com/zamesilyasa/android-map…

ae6c896

…s-utils into issue-82

broady assigned markmcd Jan 11, 2016

markmcd reviewed Feb 15, 2016
View reviewed changes

zamesilyasa added 2 commits March 7, 2016 00:00

Merge branch 'master' into issue-82

9db3838

stephenmcd force-pushed the master branch from 9de1a8e to 80871a4 Compare June 10, 2016 03:12

Merge remote-tracking branch 'google/master' into issue-82

4a34125

jeffdgr8 and others added 2 commits December 21, 2016 01:45

Merge pull request #1 from jeffdgr8/conditional-screen-based-algorith…

42e8df3

…m-wrap Don't wrap Algorithm if already implements ScreenBasedAlgorithm

jeffdgr8 mentioned this pull request Nov 8, 2017

Optimized quad tree and cluster algorithm with HashSet instead of ArrayList #368

Merged

stephenmcd merged commit 42e8df3 into googlemaps:master Apr 17, 2018

stephenmcd mentioned this pull request Apr 17, 2018

Is there a way to just renderer the visible clusters and items? #82

Closed

mierzynskim mentioned this pull request Aug 20, 2018

Voting: Map Marker Clustering amay077/Xamarin.Forms.GoogleMaps#123

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Render only visible items on the map #217

Render only visible items on the map #217

zamesilyasa commented Oct 19, 2015

barbeau commented Oct 19, 2015

barbeau commented Oct 21, 2015

meierjan commented Nov 11, 2015

Dima564 commented Jan 7, 2016

broady commented Jan 11, 2016

markmcd commented Feb 15, 2016

markmcd Feb 15, 2016

zamesilyasa Feb 16, 2016

markmcd Feb 17, 2016

zamesilyasa Feb 18, 2016

markmcd Feb 24, 2016

barbeau commented Feb 15, 2016

larten commented Mar 11, 2016

zamesilyasa commented Mar 11, 2016

larten commented Mar 11, 2016

zamesilyasa commented Mar 11, 2016

larten commented Mar 11, 2016

meierjan commented Mar 29, 2016

lmbd commented Sep 1, 2016

zamesilyasa commented Sep 1, 2016

lfdversluis commented Oct 6, 2016

zamesilyasa commented Oct 6, 2016

lfdversluis commented Oct 6, 2016

googlebot commented Feb 3, 2017

jeffdgr8 commented Feb 13, 2017

b1n0m13 commented May 5, 2017

zamesilyasa commented Jun 30, 2017 •

edited

Loading

zamesilyasa commented Jun 30, 2017

manish-bansal commented Apr 16, 2018

stephenmcd commented Apr 17, 2018

manish-bansal commented Apr 17, 2018

manish-bansal commented May 29, 2018

tmiyamon commented Jul 20, 2018

lordplagus02 commented Dec 19, 2018

Render only visible items on the map #217

Render only visible items on the map #217

Conversation

zamesilyasa commented Oct 19, 2015

barbeau commented Oct 19, 2015

barbeau commented Oct 21, 2015

meierjan commented Nov 11, 2015

Dima564 commented Jan 7, 2016

broady commented Jan 11, 2016

markmcd commented Feb 15, 2016

markmcd Feb 15, 2016

Choose a reason for hiding this comment

zamesilyasa Feb 16, 2016

Choose a reason for hiding this comment

markmcd Feb 17, 2016

Choose a reason for hiding this comment

zamesilyasa Feb 18, 2016

Choose a reason for hiding this comment

markmcd Feb 24, 2016

Choose a reason for hiding this comment

barbeau commented Feb 15, 2016

larten commented Mar 11, 2016

zamesilyasa commented Mar 11, 2016

larten commented Mar 11, 2016

zamesilyasa commented Mar 11, 2016

larten commented Mar 11, 2016

meierjan commented Mar 29, 2016

lmbd commented Sep 1, 2016

zamesilyasa commented Sep 1, 2016

lfdversluis commented Oct 6, 2016

zamesilyasa commented Oct 6, 2016

lfdversluis commented Oct 6, 2016

googlebot commented Feb 3, 2017

jeffdgr8 commented Feb 13, 2017

b1n0m13 commented May 5, 2017

zamesilyasa commented Jun 30, 2017 • edited Loading

zamesilyasa commented Jun 30, 2017

manish-bansal commented Apr 16, 2018

stephenmcd commented Apr 17, 2018

manish-bansal commented Apr 17, 2018

manish-bansal commented May 29, 2018

tmiyamon commented Jul 20, 2018

lordplagus02 commented Dec 19, 2018

zamesilyasa commented Jun 30, 2017 •

edited

Loading