Validate config from external docs #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing this required some refactoring to make it easier to validate Config without having to e.g pass in logger, filter registry etc. This adds a dedicated server builder for configuring and validating a Config before creating a Server.
markmandel
reviewed
Sep 11, 2020
src/proxy/server.rs
Outdated
| /// registry for the set of available filters | ||
| filter_registry: FilterRegistry, | ||
| metrics: Metrics, | ||
| pub(in crate::proxy) log: Logger, |
There was a problem hiding this comment.
I didn't know you could do that - very nice. Might be worth putting a comment here about why we need access to these variables from crate::proxy -- I'm assuming its because of the builder?
There was a problem hiding this comment.
Yes! this was because of the builder, added comment!
src/proxy/server_builder.rs
Outdated
| } | ||
|
|
||
| /// Represents the components needed to create a Server. | ||
| pub struct ServerBuilder<V> { |
There was a problem hiding this comment.
Builder rather than ServerBuilder?
Just thinking it might be nice to have quilkin::proxy::builder::Builder - not wedded to it, just wondering if the thought stuck.
|
Oops! Looks like the rename broke the doc tests (which is great that we have them!) Other than that, this is good to go for sure! Nice stuff! |
markmandel
added
kind/cleanup
markmandel
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this required some refactoring to make it easier to
validate Config without having to e.g pass in logger, filter registry
etc. This adds a dedicated server builder for configuring and
validating a Config before creating a Server.