Fix timestamp/duration unit confusion #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Shadle
requested review from
markmandel,
XAMPPRocky and
koslib
as code owners
Jake-Shadle
changed the title
XAMPPRocky
approved these changes
Apr 4, 2024
|
Build Succeeded 🥳 Build Id: 909ba8bb-70cc-4e96-b8ab-aacdfeed4230 The following development images have been built, and will exist for the next 30 days: To build this version: |
markmandel
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a big mistake in #896 by changing the units of various timestamps from nanoseconds -> seconds, which caused QCMP distances to be completely wrong as the unit change caused all calculations to be 0. This fixes the bug by actually having a modicum of type safety so that all conversions between timestamps and duration/nanoseconds are clear as opposed to "losing" the units. It also changes the
qcmp::pingtest to force a delay and ensure that the calculated time is both less than twice the delay but also greater than the delay, which was why this bug was not detected by the test.Resolves: #920