-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move non-linux builds to github #899
Conversation
Have to defer @markmandel here, I think there might be some google policy here that prevents this, otherwise I'm all for it. |
4bab636
to
0df0305
Compare
This allows CI to still check windows/macos compile, but actually run in parallel rather than serializing on each platform and wasting valuable CI time
4f47d1a
to
705c67d
Compare
Build Succeeded 🥳 Build Id: 876b0449-2dbf-426e-b576-499c76f9fc99 The following development images have been built, and will exist for the next 30 days: To build this version:
|
I had a refresh of our current policies - and GitHub Actions is now definitely on the table 🙌🏻! I would limit it to anything that doesn't maintain an artifact of some kind / interact with the Google Cloud infrastructure though. Using Cloud Build where there is an artifact, means there's a direct path between the Google Cloud infra - where the artifact gets built - and where it ends up being hosted (even if it ends up being a download on GitHub, it's going through a Google laptop), so we can lean on Google as a whole for security pipeline -- but for just testing, this is totally fine. The only thought I have is that the current So I'm happy to merge unless that is a bigger concern for anyone else? |
This allows CI to still check windows/macos compile, but actually run in parallel rather than serializing on each platform and wasting valuable CI time