Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move non-linux builds to github #899

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Move non-linux builds to github #899

merged 6 commits into from
Mar 4, 2024

Conversation

Jake-Shadle
Copy link
Collaborator

This allows CI to still check windows/macos compile, but actually run in parallel rather than serializing on each platform and wasting valuable CI time

@XAMPPRocky
Copy link
Collaborator

Have to defer @markmandel here, I think there might be some google policy here that prevents this, otherwise I'm all for it.

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 876b0449-2dbf-426e-b576-499c76f9fc99

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/899/head:pr_899 && git checkout pr_899
cargo build

@markmandel
Copy link
Member

I had a refresh of our current policies - and GitHub Actions is now definitely on the table 🙌🏻!

I would limit it to anything that doesn't maintain an artifact of some kind / interact with the Google Cloud infrastructure though. Using Cloud Build where there is an artifact, means there's a direct path between the Google Cloud infra - where the artifact gets built - and where it ends up being hosted (even if it ends up being a download on GitHub, it's going through a Google laptop), so we can lean on Google as a whole for security pipeline -- but for just testing, this is totally fine.

The only thought I have is that the current build step via Cloud Build also tests that the cross platform build works at release time. It's probably going to be fine / can be fixed at release time if something does break, but just something to consider. Also since we release every couple of months, and we run CI all the time, the benefit definitely outweighs any extra time we spend at release.

So I'm happy to merge unless that is a bigger concern for anyone else?

@XAMPPRocky XAMPPRocky merged commit 490e538 into main Mar 4, 2024
10 checks passed
@markmandel markmandel deleted the move-non-linux-github branch March 11, 2024 06:00
@markmandel markmandel added kind/feature New feature or request area/build-tools Development tooling. labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. kind/feature New feature or request size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants