Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End to End test for the TestFilter #64

Merged
merged 1 commit into from
Jul 6, 2020
Merged

End to End test for the TestFilter #64

merged 1 commit into from
Jul 6, 2020

Conversation

markmandel
Copy link
Contributor

End to end test of the TestFilter implementation, proving an integration test for the full Filter trait experience.

Work on #1

@markmandel
End to End test for the TestFilter
e034508 
End to end test of the TestFilter implementation, proving an integration
test for the full Filter trait experience.

Work on #1
@markmandel markmandel added the area/tests Unit tests, integration tests, anything to make sure things don't break label Jun 30, 2020
iffyio
iffyio approved these changes Jul 1, 2020
View reviewed changes
Copy link
Collaborator

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markmandel markmandel merged commit 9819437 into master Jul 6, 2020
@markmandel markmandel deleted the test/test-filter-e2e branch July 7, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iffyio iffyio iffyio approved these changes

Assignees
No one assigned
Labels
area/tests Unit tests, integration tests, anything to make sure things don't break cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @iffyio @googlebot