(Mostly) Build tools working on arm64 #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using linux/arm64 at the test environment, this implements almost all of getting the build toolchain working on an arm64 host machine. `make build-macos-binary` is currently not working, but I've left that for later, and documented it as a known issue. Everything else is working! Also includes: * Cleanup unneeded things in build image. * Updates to linkers used when cross compiling. * Document known issues with compiling mac binaries. * Ensure emulation exists where required. Work on #googleforgames#608
markmandel
added
kind/feature
markmandel
requested review from
XAMPPRocky,
luna-duclos,
rezvaneh and
vallfors
as code owners
|
Build Succeeded 🥳 Build Id: b990c8b8-3661-4c8f-b968-143dfbcd76bd The following development images have been built, and will exist for the next 30 days: To build this version: |
XAMPPRocky
approved these changes
Sep 30, 2022
XAMPPRocky
pushed a commit
that referenced
this pull request
Oct 10, 2022
Using linux/arm64 at the test environment, this implements almost all of getting the build toolchain working on an arm64 host machine. `make build-macos-binary` is currently not working, but I've left that for later, and documented it as a known issue. Everything else is working! Also includes: * Cleanup unneeded things in build image. * Updates to linkers used when cross compiling. * Document known issues with compiling mac binaries. * Ensure emulation exists where required. Work on ##608
XAMPPRocky
pushed a commit
that referenced
this pull request
Oct 10, 2022
Using linux/arm64 at the test environment, this implements almost all of getting the build toolchain working on an arm64 host machine. `make build-macos-binary` is currently not working, but I've left that for later, and documented it as a known issue. Everything else is working! Also includes: * Cleanup unneeded things in build image. * Updates to linkers used when cross compiling. * Document known issues with compiling mac binaries. * Ensure emulation exists where required. Work on ##608
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Using linux/arm64 at the test environment, this implements almost all of getting the build toolchain working on an arm64 host machine.
make build-macos-binaryis currently not working, but I've left that for later, and documented it as a known issue.Everything else is working!
Also includes:
Which issue(s) this PR fixes:
Work on ##608
Special notes for your reviewer:
This also sets us up for: