archive_dependencies.sh: Handle no dependencies #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are no dependencies utilised that we need to archive source for, this breaks the build process since no dependencies-src.zip file is created, and the Dockerfile has nothing to copy. This changes the script such that it starts with an empty zip file, and then appends dependencies if and when they exist. Unblocks googleforgames#457
markmandel
added
kind/bug
XAMPPRocky
approved these changes
Jan 11, 2022
iffyio
approved these changes
Jan 11, 2022
|
Build Succeeded 🥳 Build Id: b422f8e8-f8c8-4ab2-8115-9a7291cf3784 To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
If there are no dependencies utilised that we need to archive source for, this breaks the build process since no dependencies-src.zip file is created, and the Dockerfile has nothing to copy.
This changes the script such that it starts with an empty zip file, and then appends dependencies if and when they exist.
Which issue(s) this PR fixes:
Unblocks #457
Special notes for your reviewer:
If @XAMPPRocky is still on vacation, this will let us merge #457, and I can handle the removal of
slog-jsonfrom this script separately. Since the dependency is no longer used, the library isn't on the cloud build machine, so the archive zip is correct even with the item in thedependencieslist.