xds-server: Create informers before starting informer factory #446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Fixes the Kubernetes controller implementation of the xds management server. Without the fix, the controller isn't able to list any
GameServers
orPods
in the cluster, and doesn't update connected Quilkin instances with endpoints.The informer factory only starts informers that were already requested when
Start()
is called. The informers are requested when getting the Lister for a specific type. As we are callingLister()
afterStart()
, the informer never watches for the resources, andList()
will always return the empty list.Which issue(s) this PR fixes:
Special notes for your reviewer: