Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save iperf3 metrics.json in /quilkin #438

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

markmandel
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This makes sure the output of the metrics snapshot can be captured by the volume mount when running the container.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

This makes sure the output of the metrics snapshot can be captured by
the volume mount when running the container.
@markmandel markmandel added kind/bug Something isn't working area/examples Examples. Usually found in the `examples` directory area/performance Anything to do with Quilkin being slow, or making it go faster. labels Nov 17, 2021
@google-cla google-cla bot added the cla: yes label Nov 17, 2021
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: b8ce3f6d-90ba-434e-a5a5-7c2e07601dc4

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/438/head:pr_438 && git checkout pr_438
cargo build

@XAMPPRocky XAMPPRocky merged commit c47780b into googleforgames:main Nov 17, 2021
@markmandel markmandel deleted the perf/save-metrics branch November 17, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples Examples. Usually found in the `examples` directory area/performance Anything to do with Quilkin being slow, or making it go faster. cla: yes kind/bug Something isn't working size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants