Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move xds-management-server to the top-level #435

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Move xds-management-server to the top-level #435

merged 2 commits into from
Nov 12, 2021

Conversation

XAMPPRocky
Copy link
Collaborator

After merging #360 I noticed that the project was in examples/ which doesn't seem right, as it's designed to be used, not just as an example. So this just moves it to a top-level xds/ folder instead.

@markmandel
Copy link
Contributor

🤔 @iffyio be curious to hear your thoughts on this.

My thought was that this would be a way you could integrate Agones, but possibly not the way? I.e. if you wanted to base your integration on this you could (which led me to have this in the examples folder), if we move it up to the top level, are we expected to put out a Docker image, etc, and make it a more complete solution?

I just want to manage expectations appropriately.

@iffyio
Copy link
Collaborator

iffyio commented Nov 11, 2021

Ah so this is one server to use indeed, the idea isn't for folks to extend it. If someone wants something different they'll need to either roll their own implementation separately like we did here or fork this to add their change. We'll need docker images etc for this yeah

@markmandel
Copy link
Contributor

Ah so this is one server to use indeed, the idea isn't for folks to extend it. If someone wants something different they'll need to either roll their own implementation separately like we did here or fork this to add their change. We'll need docker images etc for this yeah

Got it. Awesome, then if that's the plan, let's definitely move this up a level.

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 2ba9e611-9597-46f6-b7ca-273317611542

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/435/head:pr_435 && git checkout pr_435
cargo build

@iffyio iffyio merged commit 057df81 into main Nov 12, 2021
@iffyio iffyio deleted the mv-xds branch November 12, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants