Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add cross compile and basic image test #370

Merged
merged 2 commits into from
Aug 18, 2021

Conversation

markmandel
Copy link
Contributor

Identifying that we accidentally keep breaking either the release process and/or the released container images since we don't automate testing of it.

So this PR does several things:

  • Fix the issues I found in compiling for macos when testing this CI improvement.
  • Adds cross compilation into the CI process.
  • Add building the image into the CI process.
  • Run the Quilkin release and debug images against their default configuration (which does nothing) for a few seconds, to make sure they don't error.
  • Increase build image to 32 cores, which keeps the CI build process to ~13 minutes, which is not too bad.

Long term, if we wanted to keep images/binaries temporarily for PR builds, we can also do so.

Work on #318

Identifying that we accidentally keep breaking either the release
process and/or the released container images since we don't automate
testing of it.

So this PR does several things:

* Fix the issues I found in compiling for macos when testing this CI
improvement.
* Adds cross compilation into the CI process.
* Add building the image into the CI process.
* Run the Quilkin release and debug images against their default
configuration (which does nothing) for a few seconds, to make sure they
don't error.
* Increase build image to 32 cores, which keeps the CI build process to
~13 minutes, which is not too bad.

Long term, if we wanted to keep images/binaries temporarily for PR
builds, we can also do so.

Work on googleforgames#318
@markmandel markmandel added kind/feature New feature or request area/build-tools Development tooling. labels Aug 17, 2021
@google-cla google-cla bot added the cla: yes label Aug 17, 2021
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 1ce0d5d8-0078-4fb2-a52e-941bcc8b83ce

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/370/head:pr_370 && git checkout pr_370
cargo build

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 5b1f61a7-75ef-4a26-a36e-8f67ccf7ac61

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/370/head:pr_370 && git checkout pr_370
cargo build

@markmandel markmandel merged commit 06b3e71 into googleforgames:main Aug 18, 2021
@markmandel markmandel deleted the ci/test-image branch August 18, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. cla: yes kind/feature New feature or request size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants