Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default configuration file conventions. #279

Merged
merged 1 commit into from
May 26, 2021
Merged

Add default configuration file conventions. #279

merged 1 commit into from
May 26, 2021

Conversation

XAMPPRocky
Copy link
Collaborator

fixes #270

@XAMPPRocky XAMPPRocky requested a review from iffyio May 25, 2021 17:25
@google-cla google-cla bot added the cla: yes label May 25, 2021
@XAMPPRocky XAMPPRocky requested a review from markmandel May 25, 2021 17:25
@quilkin-bot

This comment has been minimized.

Sign in to view
@XAMPPRocky
Copy link
Collaborator Author

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/279/head:pr_279 && git > checkout pr_279
cargo build

Btw you could condense this down to gh pr checkout 279 if you use the GitHub cli tool.

@quilkin-bot

This comment has been minimized.

Sign in to view
@markmandel
Copy link
Contributor

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/279/head:pr_279 && git > checkout pr_279
cargo build

Btw you could condense this down to gh pr checkout 279 if you use the GitHub cli tool.

I didn't want to assume that people have specific tooling. If you are on Github, you have to have git.

markmandel
markmandel approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @iffyio any issues on your end?

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: a2533a60-b7aa-43fc-be2b-cdf9aa4cb007

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/279/head:pr_279 && git checkout pr_279
cargo build

@XAMPPRocky XAMPPRocky merged commit d355f85 into main May 26, 2021
@XAMPPRocky XAMPPRocky deleted the quilkin-file branch May 26, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iffyio iffyio iffyio approved these changes

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convention: quilkin.yaml file
4 participants
@XAMPPRocky @quilkin-bot @markmandel @iffyio