Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for writing filters #243

Merged
merged 6 commits into from
May 12, 2021
Merged

Add documentation for writing filters #243

merged 6 commits into from
May 12, 2021

Conversation

iffyio
Copy link
Collaborator

@iffyio iffyio commented May 4, 2021

There are a few placeholder links to code items that we would need to be update when we're able to link to them on crates.io

Work on #62

@iffyio iffyio requested review from markmandel and XAMPPRocky May 4, 2021 18:52
@google-cla google-cla bot added the cla: yes label May 4, 2021
Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Just a couple of small questions.

docs/extensions/filters/writing_custom_filters.md Outdated Show resolved Hide resolved
docs/extensions/filters/writing_custom_filters.md Outdated Show resolved Hide resolved
@XAMPPRocky
Copy link
Collaborator

Whoops, too many tabs 😅

Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes, just because of missing licences, and I don't want to get in trouble with our OSPO team 😄

examples/quilkin-filter-example/build.rs Show resolved Hide resolved
examples/quilkin-filter-example/config.yaml Show resolved Hide resolved
examples/quilkin-filter-example/Cargo.toml Show resolved Hide resolved
examples/quilkin-filter-example/.gitignore Outdated Show resolved Hide resolved
examples/quilkin-filter-example/src/main.rs Show resolved Hide resolved
examples/quilkin-filter-example/.gitignore Show resolved Hide resolved
@iffyio iffyio requested a review from markmandel May 7, 2021 06:35
Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! This is the last bit for our 0.1.0 launch!

@markmandel markmandel merged commit 52a58ec into main May 12, 2021
@markmandel markmandel deleted the iu/writing-filters branch May 12, 2021 00:10
@markmandel markmandel added the kind/documentation Improvements or additions to documentation label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes kind/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants