Release and Debug image release pipeline #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appends to the release `cloudbuild.yaml` to create a release and debug tagged image when run based on the `distroless` image. This also includes several steps that are needed for ongoing internal compliance - such as maintaining a list of dependencies and their licences, zipping MPL licenced code, etc. Fixes #201
markmandel
added
kind/feature
markmandel
commented
Mar 15, 2021
| # limitations under the License. | ||
| # | ||
|
|
||
| version: v1alpha1 |
There was a problem hiding this comment.
This was the best idea I had for a default config - basically traffic goes nowhere.
Wasn't sure if we should have it instead go to something like "localhost:8000" ??? WDYT?
There was a problem hiding this comment.
Having it go nowhere sounds reasonable to me!
markmandel
commented
Mar 15, 2021
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| }}"External Library Name","Link to License","License Name" |
There was a problem hiding this comment.
I needed this for some internal compliance, so figured I would keep it in case we ever needed it again.
iffyio
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appends to the release
cloudbuild.yamlto create a release and debug tagged image when run based on thedistrolessimage.This also includes several steps that are needed for ongoing internal compliance - such as maintaining a list of dependencies and their licences, zipping MPL licenced code, etc.
Fixes #201