Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validated config type #207

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Add validated config type #207

merged 2 commits into from
Mar 11, 2021

Conversation

iffyio
Copy link
Collaborator

@iffyio iffyio commented Mar 7, 2021

A ValidatedConfig type is returned after validating a
config, so that any code that relies on config invariants do
not need to re-validate the config.

Fixes #172

A ValidatedConfig type is returned after validating a
config, so that any code that relies on config invariants do
not need to re-validate the config.

Fixes #172
@iffyio iffyio requested a review from markmandel March 7, 2021 16:08
@google-cla google-cla bot added the cla: yes label Mar 7, 2021
Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@markmandel markmandel merged commit 14b1b31 into main Mar 11, 2021
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Mar 11, 2021
@iffyio iffyio deleted the iu/validated-config branch May 5, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark a configuration as having passed validation before using it
2 participants