Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated development and community documentation #127

Merged
merged 2 commits into from
Nov 7, 2020
Merged

Conversation

markmandel
Copy link
Contributor

This PR includes several enhancements to help onboard more people onto the project, and set us on a good path for when we want the project to go public:

  1. Push cloudbuild logs into a specified google cloud storage bucket, which is public for easy access.
  2. Updated contributing guide with updated details of development practices (The resources they point to are real as well).
  3. Updated README.md with updated documentation, and community links.

Closes #119

@markmandel markmandel added kind/documentation Improvements or additions to documentation area/community Pertaining to the community - i.e. Discord, mailing list, etc area/build-tools Development tooling. labels Nov 5, 2020
@google-cla google-cla bot added the cla: yes label Nov 5, 2020
Copy link
Collaborator

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CONTRIBUTING.md Outdated
@@ -27,23 +27,74 @@ Participation in this project comes under the [Contributor Covenant Code of Cond
"[kind/design](https://github.com/googleprivate/agones/issues?q=is%3Aissue+is%3Aopen+label%3Akind%2Fdesign)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can update the link referencing agones

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG. Lemme fix that.

This PR includes several enhancements to help onboard more people onto
the project, and set us on a good path for when we want the project to
go public:

1. Push cloudbuild logs into a specified google cloud storage bucket,
which is public for easy access.
1. Updated contributing guide with updated details of development
practices (The resources they point to are real as well).
1. Updated README.md with updated documentation, and community links.

Closes #119
@markmandel markmandel merged commit d33f6ca into master Nov 7, 2020
@markmandel markmandel deleted the build/dev-update branch November 7, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. area/community Pertaining to the community - i.e. Discord, mailing list, etc cla: yes kind/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public chat room
2 participants