Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples need updating to new config format #559

Closed
Tracked by #546
markmandel opened this issue Aug 9, 2022 · 0 comments
Closed
Tracked by #546

Examples need updating to new config format #559

markmandel opened this issue Aug 9, 2022 · 0 comments
Labels
area/examples Examples. Usually found in the `examples` directory kind/bug Something isn't working

Comments

@markmandel
Copy link
Contributor

markmandel commented Aug 9, 2022

What happened:

Running through all the examples, they break because they have the old config yaml fomat.

What you expected to happen:

For them to work.

How to reproduce it (as minimally and precisely as possible):

./target/debug/quilkin -c ./examples/agones-xonotic/client-compress.yaml run

Anything else we need to know?:

Should be easy enough to fix.

Environment:

  • Quilkin version: dev
  • Execution environment (binary, container, etc): binary
  • Operating system: Linyx
  • Custom filters? (Yes/No - if so, what do they do?): No
  • Log(s):
➜  quilkin git:(bug/mdbook-yaml) ✗ ./target/debug/quilkin -c ./examples/agones-xonotic/client-compress.yaml run
{"timestamp":"2022-08-09T00:46:18.250183Z","level":"INFO","fields":{"message":"Starting Quilkin","version":"0.4.0-dev+debug","commit":"25d93603c7c83603def8e79d26a390d5dc83755f"},"target":"quilkin"}
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: filter `quilkin.extensions.filters.compress.v1alpha1.Compress` not found at line 17 column 8', src/main.rs:195:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
  • Others: N/A
@markmandel markmandel added kind/bug Something isn't working area/examples Examples. Usually found in the `examples` directory labels Aug 9, 2022
markmandel added a commit to markmandel/quilkin that referenced this issue Aug 25, 2022
Updates for core examples, agones-xonotic, and iperf3

Still need to do the custom-filter-example, but wanted to do that in
conjunction with the documentation update.

Work on googleforgames#559
XAMPPRocky added a commit that referenced this issue Aug 26, 2022
Updates for core examples, agones-xonotic, and iperf3

Still need to do the custom-filter-example, but wanted to do that in
conjunction with the documentation update.

Work on #559

Co-authored-by: XAMPPRocky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples Examples. Usually found in the `examples` directory kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants