Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Disable HTTP supports for MMF and Evaluator #753

Closed
yfei1 opened this issue Aug 19, 2019 · 0 comments
Closed

Discussion: Disable HTTP supports for MMF and Evaluator #753

yfei1 opened this issue Aug 19, 2019 · 0 comments
Labels
help wanted Extra attention is needed question Further information is requested
Milestone

Comments

@yfei1
Copy link
Collaborator

yfei1 commented Aug 19, 2019

When working on #744, I realized we may need to change a bunch of files and expose some internal types to make the tests work.

After some further thoughts I am thinking about whether we really need HTTP supports for the MMFs and the Evaluators. MMF and Evaluator are customized components which won't be called directly and the only way to trigger the MMF and Evaluator is via our internal components. Therefore, disabling HTTP supports for the MMF and Evaluator won't hurt our usability and core functionalities.

@Laremere @sawagh What do you think about this proposal?

@yfei1 yfei1 added help wanted Extra attention is needed question Further information is requested labels Aug 19, 2019
@sawagh sawagh added this to the v0.7.0 milestone Aug 23, 2019
@sawagh sawagh closed this as completed Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants