Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP support for evaluator.Evaluate #744

Closed
yfei1 opened this issue Aug 16, 2019 · 1 comment · Fixed by #754
Closed

Add HTTP support for evaluator.Evaluate #744

yfei1 opened this issue Aug 16, 2019 · 1 comment · Fixed by #754
Assignees
@yfei1
Milestone
v0.7.0

Comments

@yfei1
Copy link
Collaborator

yfei1 commented Aug 16, 2019 •
edited
Loading

We don't have a test for the evaluator using its HTTP endpoint yet. Also #745 disable the support for evaluator.Evaluate function.
@yfei1 yfei1 self-assigned this Aug 16, 2019
@yfei1 yfei1 changed the title Add test for evaluator's HTTP endpoint Add HTTP support for evaluator.Evaluate Aug 16, 2019
@yfei1 yfei1 mentioned this issue Aug 16, 2019
Merged
@yfei1
Copy link
Collaborator Author

yfei1 commented Aug 19, 2019 •
edited
Loading

Blocked by grpc-ecosystem/grpc-gateway#999
Fixed.

This was referenced Aug 19, 2019
Closed
Merged
@sawagh sawagh added this to the v0.7.0 milestone Aug 23, 2019
@sawagh sawagh closed this as completed Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yfei1 yfei1

Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Evaluator http test and implementation yfei1/open-match
2 participants
@sawagh @yfei1