Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed various spelling mistakes #192

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed various spelling mistakes #192

wants to merge 1 commit into from

Conversation

aLekSer
Copy link
Contributor

@aLekSer aLekSer commented Sep 8, 2020

Note that there is a need to update comments in proto files.

akremsa
akremsa reviewed Sep 8, 2020
View reviewed changes
site/content/en/docs/Guides/Evaluator/_index.md Outdated
@@ -36,7 +36,7 @@ The Director could request for the following Profiles:

In this case, the MatchFunction executing Profile1 and Profile2 will have some common players they consider for generating Matches (Similarly with Profile2 and Profile3). Thus, the generated Matches may have overlapping Tickets.

This overlap is desired in some real matchmaking scenarios, . Inorder to generate high quality Matches, you may want your Ticket to be considered concurrently for multiple possible MatchProfiles and then be able to compare the quality of these overlapping Matches, picking the highest quality Match and discarding the rest. For instance in the above example, a Ticket with mmr 3 could be a part of a Matches generated by Profile1 and Profile2. Based on the game design and the mmr of other Tickets in these overlapping Matches, one of these two Matches may actually be a better fit for this Ticket - and thus, searching for Matches with overlapping mmr ranges resulted in considering 2 options for this Ticket and picking the better fit.
This overlap is desired in some real matchmaking scenarios. In order to generate high quality Matches, you may want your Ticket to be considered concurrently for multiple possible MatchProfiles and then be able to compare the quality of these overlapping Matches, picking the highest quality Match and discarding the rest. For instance in the above example, a Ticket with mmr 3 could be a part of a Matches generated by Profile1 and Profile2. Based on the game design and the mmr of other Tickets in these overlapping Matches, one of these two Matches may actually be a better fit for this Ticket - and thus, searching for Matches with overlapping mmr ranges resulted in considering 2 options for this Ticket and picking the better fit.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a comma after "For instance".

@aLekSer aLekSer mentioned this pull request Sep 8, 2020
Merged
@thisisnotapril
Copy link
Collaborator

Can we close this one?

@aLekSer
Copy link
Contributor Author

aLekSer commented Oct 1, 2020

I assume this one should be merged, WDYT?

@aLekSer
Fixed various spelling mistakes
b8d6a35 
Note that there is a need to update comments in proto files.
@aLekSer
Copy link
Contributor Author

aLekSer commented Nov 26, 2020 •
edited
Loading

It seems that this is a random flaky test and not related to the changes:

   throw err;
    ^

Error: Cannot find module 'postcss'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:690:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/workspace/node_modules/postcss-cli/index.js:13:17)
    at Module._compile (internal/modules/cjs/loader.js:776:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
ERROR 2020/10/06 12:25:07 error: failed to transform resource: exit status 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akremsa akremsa akremsa approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aLekSer @thisisnotapril @akremsa @googlebot