-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unreal] Refactor agones component to subsystem #4033
base: main
Are you sure you want to change the base?
[Unreal] Refactor agones component to subsystem #4033
Conversation
Build Succeeded 🥳 Build Id: 3ab0bc2c-9618-471a-af73-0f58076bc7d9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Failed 😭 Build Id: 25d7e15e-cdf9-4b3c-a2b3-6d160f0177d3 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
/gcbrun |
Build Succeeded 🥳 Build Id: f3e2be54-b83b-4fda-ae32-fdb1375a3cc7 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind breaking
/kind documentation
/kind feature
What this PR does / Why we need it:
Refactor agones from using ActorComponent to GameInstanceSubsystem:
Removed final keyword, to allow basing of Subsystem and overriding behavior.
Added bDisableAutoHealthPing to disable auto call to HealthPing() during init
Added blueprint readonly flag support for HealthRateSeconds, bDisableAutoHealthPing, bDisableAutoConnect so controlling subsystem calls from BPs would be easier.
Added static Get() of subsystem, so it would be easily obtained from anywhere you have a context object.
Space&Tabs mix change to just Tabs
Special notes for your reviewer:
That is something we used internally for some time already and I think people can benefit from that change.
This change would break code that was previously dependent on AgonesComponent.