Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combining dieresis is misnamed in uni1E85.sc recipe? #309

Closed
tphinney opened this issue Dec 7, 2023 · 2 comments
Closed

combining dieresis is misnamed in uni1E85.sc recipe? #309

tphinney opened this issue Dec 7, 2023 · 2 comments
Assignees
Labels
bug Something isn't working next build

Comments

@tphinney
Copy link
Collaborator

tphinney commented Dec 7, 2023

I would have fixed this myself, but I am torn on which fix is better, so… let me explain.

I see this for every master of uni1E85.sc (small cap w with dieresis):

Warning: generated 'uni1E85.sc:Blk Exp Ctr S', ignoring the missing 'dieresiscomb'

The problem is that the "dieresiscomb" is actually named "uni0308" in the font

We do have "acutecomb" and others in the font, pretty sure the "dieresiscomb" name is in AGL, so maybe instead of changing this one recipe, we could/should actually rename the "uni0308" and "uni0308.case" using FontLab internal tools? Would that update the relevant other recipes?

@kateliev feel free to pick the option you think is better here.

@tphinney tphinney added the bug Something isn't working label Dec 7, 2023
@kateliev
Copy link
Member

kateliev commented Dec 8, 2023

Would that update the relevant other recipes?

I highly doubt it :)

We do have "acutecomb" and others in the font, pretty sure the "dieresiscomb" name is in AGL, so maybe instead of changing this one recipe, we could/should actually rename the "uni0308" and "uni0308.case" using FontLab internal tools? Would that update the relevant other recipes?
As far as i am concerned i would have renamed it to "dieresiscomb" just beacause the others follow the same logic.
image

Actually now that we discuss it... why aren't we using friendly names instead of the uniXXXX standard in the whole font. I presume there was a specific reason but 3-4 years later i seem to have forgotten what it was. Hmm this whole leads me to the following worrisome taught/question that i will further explain in #302

@tphinney tphinney moved this to To do in Science Gothic VF Jun 10, 2024
kateliev added a commit that referenced this issue Aug 6, 2024
- Changed hhea values to match Family dimensions for all masters;

Issue #309: Combining dieresis is misnamed in uni1E85.sc recipe?
- Renamed /uni0308 and /uni0308.case to /dieresiscomb and /dieresiscomb.case
- Fixed recipes for  /edieresis /idieresis /odieresis /udieresis /ydieresis /Adieresis /Edieresis /Idieresis /Odieresis /Udieresis /adieresis /Ydieresis /Wdieresis /wdieresis /adieresis.sc /edieresis.sc /idieresis.sc /odieresis.sc /udieresis.sc /ydieresis.sc /wdieresis.sc /adieresis.slnt

Issue #341: Need “design right” symbol:
- Some finishing touches;
@kateliev
Copy link
Member

kateliev commented Aug 6, 2024

Fixed, together with all the recipes and .case alternates. Will be close with our next build

@tphinney tphinney moved this from To do to Done but not built in Science Gothic VF Aug 7, 2024
@github-project-automation github-project-automation bot moved this from Done but not built to Done in Science Gothic VF Aug 7, 2024
kateliev added a commit that referenced this issue Aug 7, 2024
…d with marks that replace it

Added necessary code to features as required by Google

Issue #309: Combining dieresis is misnamed in uni1E85.sc recipe?
Small bug fix in OT features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next build
Projects
Status: Done
Development

No branches or pull requests

2 participants