Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSA latin all changes #134

Closed
wants to merge 18 commits into from
Closed

SSA latin all changes #134

wants to merge 18 commits into from

Conversation

RosaWagner
Copy link
Contributor

@RosaWagner RosaWagner commented Sep 28, 2023

cc @EbenSorkin

@moyogo Does it seem all good to you, all files in sync, etc?

@RosaWagner RosaWagner changed the title Ssa latin all changes SSA latin all changes Sep 28, 2023
@RosaWagner RosaWagner requested a review from moyogo September 28, 2023 12:53
@RosaWagner RosaWagner marked this pull request as ready for review September 28, 2023 12:54
@vv-monsalve
Copy link
Contributor

Merging this to main branch would be ideal. I tried to create a custom .plist from the SSA-Latin branch but it still receives the old glyphs that shouldn't be included, e.g. rfishhook.

@RosaWagner
Copy link
Contributor Author

@vv-monsalve @moyogo @EbenSorkin I updated the lists, can the PR be merged? Or are we waiting for something else?

@vv-monsalve
Copy link
Contributor

vv-monsalve commented Oct 31, 2023

I updated the lists, can the PR be merged? Or are we waiting for something else?

@moyogo could you confirm if you are planning to make more changes in the SSA-Latin branch?

@moyogo
Copy link
Contributor

moyogo commented Nov 8, 2023

@RosaWagner @vv-monsalve Sorry for the delay. I’ve updated some language data and will use the scripts #109 to regenerate GF Latin African for SSA languages. I had missed a few things when trying to do it manually.

@vv-monsalve
Copy link
Contributor

and will use the scripts #109 to regenerate GF Latin African for SSA languages.

@moyogo did you have the opportunity to regenerate eh GF Latin African? :)

@yanone
Copy link
Collaborator

yanone commented Jan 18, 2024

This PR was originally authored before we began the transition of glyphsets to the new approach (outlined in the root README) of separately authoring language codes per glyphset, with characters being pulled in from gflanguages, rather than defining glyphsets manually.

I noticed that this PR produces conflicts with the GF Latin Core files that are now under the new approach. So at the very least, we need to make sure that the GF Latin Core are unaffected by this PR.

But I want to propose to take the opportunity to move the new African glyphsets definitions to the new approach immediately.

The purpose of the new approach is twofold:

  • Dramatically improves the authoring of glyphsets by breaking apart the definitions into a language list per glyphset with with characters being pulled in from gflanguages
  • Automatically include glyphsets under the new approach into the new shape_languages check in Fontbakery. This check relies on Shaperglot, which in turn relies on language definitions in gflanguages. To make this check even possible, glyphsets need to be in sync with gflanguages, and therefore must be derived from it via language codes rather than manually assembled which might lead to accidental differences in the glyphsets.

This last point is important because African languages contain a lot of character sequences that don't exist as a single encoded character, and therefore the new African fonts that are being authored as we speak should be checked by shape_languages especially for correctly functioning mark features, which requires the glyphsets to be defined under the new approach.

I'm very keen on pushing this transition forward, so I'm offering to author a separate PR. For this, I would need a list of languages per each new glyphset. I'm assuming that the gflanguages definitions are up-to-date for these languages, so assembling the files under the new approach should be easy.

FYI @chrissimpkins

@moyogo
Copy link
Contributor

moyogo commented Jan 19, 2024

Closing.

@moyogo moyogo closed this Jan 19, 2024
@moyogo moyogo mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants