-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the OS/2 width class to map the wdth axis #451
Conversation
This change shold have been discussed a bit more, or at least better documented. I only realized the effect of this now. I'm still not sure if I should change (and how?) the noto-source files to have them produce the same fvar/avar tables as before, or if the change is innocuous and for the good. |
but i looks to me like a breaking change, since anybody who was relying on the old behavior, namely that glyphsLib would not generate axis maps for |
I implemented this from your comments in googlefonts/fontmake#470 (comment) I think that your original comment still makes sense, and that the design locations and user locations should be able to be chosen independently. |
yes, but in a way that doesn't break existing fonts |
this is to blacklist glyphsLib 3.3.0, which changed the way width axis coordinates are interpreted (and thus the generated fvar and avar tables in variable fonts). glyphsLib v3.3.1 restores the previous behavior until we reach agreement in googlefonts/glyphsLib#483. The change in question is googlefonts/glyphsLib#451
…ng-os2"" This reverts commit 746ad75.
Possible improvement on the situation in googlefonts/fontmake#470
@anthrotype