[glyphs] Add test for anchor propagation on digraph #790
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just to sanity check that our behaviour is matching glyphs.app in the case where we have a glyph with multiple base components but which is not a ligature.
|
This seems wrong whether Glyphs.app is doing it or not. |
|
@moyogo do you mean in the sense that the generated anchors don't really make sense? I agree that the font designer should probably be either adding anchors manually or else opting out of propagation here if possible, but we definitely don't want these glyphs to be treated as ligatures. In any case we are defining 'correct' here in terms of what glyphs.app does, and this is correct by that measure. |
|
@cmyr I commented on googlefonts/glyphsLib#368 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just to sanity check that our behaviour is matching glyphs.app in the case where we have a glyph with multiple base components but which is not a ligature.
JMM