-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting STAT table and other updates #22
Conversation
- Updated build script to add STAT table with correct flags - Added Medium and SemiBold weights as required by GF - Corrected the math symbols to be better center-aligned - bumped version string
@m4rc1e Marc - I think you did the original PR to GFs on this. Do you want to do the PR for the updated version, or should I? |
If we're going to upgrade existing projects, I suggest we use the |
For the ultimate win, let's use our https://github.com/googlefonts/Unified-Font-Repository. If we encounter any issues, we should fix them in that repo. |
Thanks Marc. My original thought was to make minimal changes to the repros, but yeah, it makes sense to do a full conversion since I’m already working on the files. |
I've updated the repository to follow the UFR guidelines. One oddity is that the github automated build process requires the creation of an additional branch (gh-pages) where it stores the results of the fontbakery checks. If I am updating others' repositories (where I can't seem to generate a new repro with the UFR template), if the repro owner doesn't create that branch, then the github action will always fail. Is there a reason why the build script puts those files in a separate branch rather than in a folder within the main branch? |
Let's merge this and push it. |
Actually, let me run a QA first. |
Thanks Marc! Do you want me to handle PRing the update to GF? |
I'm updating the font to help resolve STAT table issues. Here's the changes I've made to the file:
Now only 3
Fails
Fontbakery report
Fontbakery version: 0.7.37
[1] Family checks
⚠ WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?
[9] Comfortaa-VF.ttf
🔥 FAIL: Checking file is named canonically.
🔥 FAIL: Name table strings must not contain the string 'Reserved Font Name'.
🔥 FAIL: Check glyphs do not have components which are themselves components.
⚠ WARN: Check copyright namerecords match license file.
[code: http]
⚠ WARN: License URL matches License text on name table?
[code: http]
⚠ WARN: Font has old ttfautohint applied?
⚠ WARN: Are there caret positions declared for every ligature?
⚠ WARN: Is there kerning info for non-ligated sequences?
⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
[code: lacks-kern-info]
⚠ WARN: Ensure Stylistic Sets have description.
Summary
Note: The following loglevels were omitted in this report:
Please review the updated version! Thank you.