This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Support datalab connect() to connect a GCE instance created from Deep… #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qimingj
previously approved these changes
Jan 12, 2019
tools/cli/commands/utils.py
Outdated
| @@ -68,7 +68,8 @@ class InvalidInstanceException(Exception): | |||
|
|
|||
| _MESSAGE = ( | |||
| 'The specified instance, {}, does not appear ' | |||
| 'to have been created by the `datalab` tool, and ' | |||
| 'to have been created by the `datalab` tool, or ' | |||
| 'from any GCE Deeplearning images, and ' | |||
tools/cli/commands/utils.py
Outdated
| @@ -240,22 +241,35 @@ def flatten_metadata(metadata): | |||
| return result | |||
|
|
|||
|
|
|||
| def _check_datalab_tag(instance, tags): | |||
| def _check_datalab_tag(instance, status_tags_and_metadata): | |||
|
Thanks, qimingj. PTAL |
qimingj
previously approved these changes
Jan 12, 2019
qimingj
previously approved these changes
Jan 14, 2019
|
There is a test failure. I just reran it and see if it is just flaky. |
ojarjur
reviewed
Jan 15, 2019
tools/cli/commands/utils.py
Outdated
| 'so cannot be managed by it.') | ||
| 'to have been created by the `datalab` tool, or ' | ||
| 'from any GCE Deeplearning images. Therefore it ' | ||
| 'so cannot be managed by `datalab` tool.') |
There was a problem hiding this comment.
The "so " here is redundant.
There was a problem hiding this comment.
Done. Can you grant me the write access to the repo? Thanks!
qimingj
approved these changes
Jan 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…learning images