This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Ensure that websockets are shimmed before any Jupyter client code runs. #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yebrahim
reviewed
Aug 28, 2018
| @@ -88,7 +88,9 @@ | |||
| window.datalab = {}; | |||
|
|
|||
| $("#appBar").load("<%baseUrl%>static/appbar.html", function() { | |||
| requirejs(['edit/js/main.min']); | |||
| requirejs(['websocket'], (websocket) => { | |||
There was a problem hiding this comment.
Why don't we add 'edit/js/main.min' to the list of dependencies of the websocket module? Is there a scenario where that doesn't work?
There was a problem hiding this comment.
That's the opposite sequence of what we need.
The websocket module needs to be loaded first, so it would have to be a dependency of the various main.min modules, and we do not control the code for those (they are bundled with Jupyter).
yebrahim
approved these changes
Aug 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2069