VR view is broken in the latest release version of Microsoft Edge

[rsacksteder]

VR view is broken in the following version of Microsoft Edge (which came with the Windows Creator Update):

Microsoft Edge 40.15063.0.0
Microsoft EdgeHTML 15.15063

Before updating, I was unable to reproduce the issue in the following version of Microsoft Edge:

Microsoft Edge 38.14393.1066.0
Microsoft EdgeHTML 14.14393

To reproduce this issue:

1. Visit https://developers.google.com/vr/concepts/vrview in a non-Edge browser (or an Edge version prior to the affected version) and see that you are able to pan the demo viewer just fine.
2. Attempt to interact with the same viewer in the affected version of Edge and you'll see that you can no longer pan the viewer

Interestingly I noticed that the viewer at https://storage.googleapis.com/vrview/examples/pano/index.html works okay, even with the affected version of Edge. I believe the reason for this is that an older version of VR view is being used on that page.

After noticing this, I used git bisect and found that commit f4ab19b ("Move to latest polyfill, but so far using the provided distortion correction") appears to have introduced this issue in combination with whatever changes were made recently to Microsoft Edge. Prior to that commit, the viewer appears to work even in the affected version of Edge. But any versions of the viewer from that commit and newer are broken. I suspect that the mentioned commit made a change to the Edge polyfill that is not playing nicely with the latest release version of Edge.

There don't appear to be any console errors to go off of and I set up a test with everything on the same origin, which didn't appear to resolve the issue, so it doesn't appear to be a cross-origin issue either.

[ademarre]

The panorama loads but viewport interaction with the mouse does not work.

[lincolnfrog]

I don't have the ability to test using Microsoft Edge. Please feel free to investigate, figure out a fix, and file a PR and I will gladly review.

…

On Tue, Jun 20, 2017 at 11:40 AM, Andre DeMarre ***@***.***> wrote: The panorama loads but viewport interaction with the mouse does not work. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#192 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHml0SmpwPODrXIWM0xrTtJjzAiRqSrHks5sGBINgaJpZM4N_-Nb> .

[ademarre]

In Firefox 55, VR View is breaking identically to Edge 15. Interestingly, Edge 15 and Firefox 55 both introduced WebVR support. http://caniuse.com/#feat=webvr

VR View works correctly when dom.vr.enabled is turned off in Firefox's advanced config.

In both browsers, the older version of VR View at this URL works correctly: https://storage.googleapis.com/vrview/examples/pano/index.html

[ademarre]

It also breaks on Chrome if you enable WebVR in chrome://flags/.

Verified with Chrome Version 63.0.3213.3 (Official Build) dev (64-bit) on Windows 8.1.

[jsantell]

I think this is fixed by upgrading the webvr-polyfill to 0.9.38 that includes this fix that doesn't engage the polyfill when we have full native support @lincolnfrog

[lincolnfrog]

Upgraded to webvr-polyfill 0.9.38

[sportflier]

On FF 32-bit 55.0.3 with webvr-polyfill 0.9.38, doesn't work.
JavaScript errors in build/embed.js: display is undefined (var display = this.controls.getVRDisplay();)

[jsantell]

@sportflier on desktop or mobile? Works for me on FF 55 (both with and without dom.vr.enabled on) http://googlevr.github.io/vrview/examples/video/index.html

[ssh-esoteric]

I think I found the root of this issue:

1. On desktop, FF, Chrome, and Edge all implement navigator.getVRDisplays(), but it doesn't yield any VRDevices appropriate for mouse and keyboard controls. (For me, they're all empty arrays)

2. The webvr-polyfill will not initialize itself if the browser implements navigator.getVRDisplays, so the polyfilled MouseKeyboardVRDisplay is no longer available to VRView.

Is it possible for VRView (or the polyfill) to register an instance of MouseKeyboardVRDisplay with the browser so that it's natively returned from getVRDisplays()? (Possibly by emitting a vrdisplayconnect event? - I'm not too familiar with the WebVR spec)

A temporary workaround is to forcibly enable the polyfill:

var vrPolyfill = new WebVRPolyfill;
vrPolyfill.enablePolyfill();
if (window.WebVRConfig.ENABLE_DEPRECATED_API) {
  vrPolyfill.enableDeprecatedPolyfill();
}

[jsantell]

In that case, there's an option ALWAYS_APPEND_POLYFILL_DISPLAY that will need to be added -- reopening // @lincolnfrog

[sportflier]

@jsantell I've seen the issue on desktop (Windows), but haven't tried yet on mobile or investigated setting dom.vr.enabled.

[benhamelin]

Just cloned and built this morning, on Windows 10 (thanks to #232 ) .I was getting errors in both FF and Edge from the embed.js script. I compared it to http://googlevr.github.io/vrview/build/embed.js and found them to be different, so used the copy from this URL and that solved the issue. Can't tell when the build was published.

[lincolnfrog]

We just added some information to the README advising windows users to download the builds from the github pages link you posted. I am closing this for now.

[btb]

Still broken for me, on both Firefox 58.0.2 (64-bit) and Microsoft Edge 41.16299.248.0, EdgeHTML 16.16299

Forcibly enabling polyfill does make it work.

[walkthelot]

Any luck on this? This is crazy. :(

[gctommy]

Still doesn't load on the latest Firefox.

But if anyone's looking for an alternative, A-Frame works great on both the latest Chrome and Firefox (not tested on Edge): https://aframe.io/aframe/examples/boilerplate/panorama/

[mdbarr73]

Firefox is still broken on version 62.0.3, image loads but pan does not work.