Skip to content
This repository was archived by the owner on Jun 16, 2019. It is now read-only.

Marker cluster images URLs updated #61

Closed
wants to merge 5 commits into from
Closed

Marker cluster images URLs updated #61

wants to merge 5 commits into from

Conversation

davidpelayo
Copy link

Fixes #54 and #59, at least what urls are used on this repo.

This doesn't fix those apps with the SVN based codebase which still point to the old repo, due resources aren't available (they have removed them out).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@davidpelayo davidpelayo changed the title Fixes #54 and #59 Marker cluster images URLs updated May 13, 2016
@davidpelayo
Copy link
Author

Related to #56, #57 and #60.

@davidpelayo
Copy link
Author

@WACMemphis I've updated the url to:

MarkerClusterer.prototype.MARKER_CLUSTER_IMAGE_PATH_ =
    'https://googlemaps.github.io/js-marker-clusterer/' +
    'images/m';

@googlebot
Copy link

CLAs look good, thanks!

@AlaorSilva
Copy link

The only URL that works for me on markerclusterer_compiled.js and markerclusterer.js is
https://raw.githubusercontent.com/googlemaps/js-marker-clusterer/gh-pages/images/m

Neither CDN or https://googlemaps.github.io/js-marker-clusterer/ works for me.

When I put one of above the map goes to somewhere else, and I have no markers

@ghost
Copy link

ghost commented May 13, 2016

@AlaorSilva
Works perfectly fine with CDN here. Make sure all of them end with "images/m"

stasbranger and others added 2 commits May 26, 2016 10:05
is better change also min file
Update markerclusterer_compiled.js
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@PeterTheOne
Copy link
Contributor

fixed by 2f659a3

@broady broady closed this Jun 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons gone?!
5 participants