-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(python): Add Python 3.12 #1903
Conversation
Thanks for putting this together @m-strzelczyk ! Please could you also help with testing in a downstream repo, for example I think we may need to add python 3.12 support in https://github.com/googleapis/testing-infra-docker/blob/c02d27d75de5d8f4edb90568e15f42bd9d400c91/python/googleapis/python-multi/Dockerfile#L122 which is for the To test the changes, run the following command in a clone of this repo (in the specific branch where you made changes)
Then in a downstream repo such as https://github.com/googleapis/python-bigquery-storage, run
|
I ran the commands you mentioned, but I'm not sure that it actually tested the new Not sure how to locally replicate the whole build and test process that actually runs inside the I did similar changes to |
In the monorepo we use the latest python runtime in the synthtool/synthtool/gcp/templates/python_mono_repo_library/noxfile.py.j2 Lines 419 to 420 in 74ed3eb
synthtool/synthtool/gcp/templates/python_library/noxfile.py.j2 Lines 410 to 411 in 74ed3eb
|
Will address #1903 (comment) in a separate PR |
This PR updates the post processor image to the latest one which is `gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo@sha256:957ddc3272f6b8058ff0ca2e8692b56f0a764d804fd577670385d54f19ee43d6`. The latest image adds support for python 3.12 googleapis/synthtool#1903 Run the following commands to obtain the latest sha256 ``` docker pull gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest ``` ``` docker inspect --format='{{.RepoDigests}}' gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest [gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo@sha256:957ddc3272f6b8058ff0ca2e8692b56f0a764d804fd577670385d54f19ee43d6] ```
Following what #1742 did.