Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: pull in latest typeless bot, clean up some comments #1698

Merged
merged 1 commit into from
Nov 4, 2022
Merged

samples: pull in latest typeless bot, clean up some comments #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/owlbot/nodejs/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ RUN find /synthtool -type d -exec chmod a+x {} \;
# * gts/typescript are used for linting.
# * google-gax is used for compiling protos.
RUN cd /synthtool && mkdir node_modules && npm i [email protected] [email protected] \
[email protected] @google-cloud/[email protected].2
[email protected] @google-cloud/[email protected].3

ENTRYPOINT [ "/bin/bash" ]
CMD [ "/synthtool/docker/owlbot/nodejs/entrypoint.sh" ]
2 changes: 1 addition & 1 deletion docker/owlbot/nodejs_mono_repo/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ RUN find /synthtool -type d -exec chmod a+x {} \;
# * gts/typescript are used for linting.
# * google-gax is used for compiling protos.
RUN cd /synthtool && mkdir node_modules && npm i [email protected] [email protected] \
[email protected] @google-cloud/[email protected].2
[email protected] @google-cloud/[email protected].3

ENTRYPOINT [ "/bin/bash" ]
CMD [ "/synthtool/docker/owlbot/nodejs_mono_repo/entrypoint.sh" ]
5 changes: 3 additions & 2 deletions synthtool/languages/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,14 +176,15 @@ def install(hide_output=False):
shell.run(["npm", "install"], hide_output=hide_output)


# This is currently an optional, opt-in part of an individual repo's
# OwlBot.py, and must be called from there before calling owlbot_main.
def typeless_samples_hermetic(hide_output=False):
"""
Converts TypeScript samples in the current Node.js library
to JavaScript samples. Run this step before fix() and friends.
Assumes that typeless-sample-bot is already installed in a well
known location on disk (node_modules/.bin).

This is currently an optional, opt-in part of an individual repo's
OwlBot.py, and must be called from there before calling owlbot_main.
"""
logger.debug("Run typeless sample bot")
shell.run(
Expand Down
5 changes: 3 additions & 2 deletions synthtool/languages/node_mono_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,15 @@ def install(hide_output=False):
shell.run(["npm", "install"], hide_output=hide_output)


# This is currently an optional, opt-in part of an individual repo's
# OwlBot.py, and must be called from there before calling owlbot_main.
def typeless_samples_hermetic(hide_output=False):
"""
Converts TypeScript samples in the current Node.js library
to JavaScript samples. Run this step before fix() and friends.
Assumes that typeless-sample-bot is already installed in a well
known location on disk (node_modules/.bin).

This is currently an optional, opt-in part of an individual repo's
OwlBot.py, and must be called from there before calling owlbot_main.
"""
logger.debug("Run typeless sample bot")
shell.run(
Expand Down