Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clarify the gax-nodejs usage in README #1352

Merged
merged 4 commits into from
Apr 7, 2022
Merged

fix: clarify the gax-nodejs usage in README #1352

merged 4 commits into from
Apr 7, 2022

Conversation

summer-ji-eng
Copy link
Contributor

Address issue #1351

@summer-ji-eng summer-ji-eng requested review from tmatsuo and bcoe February 9, 2022 18:34
@summer-ji-eng summer-ji-eng requested a review from a team as a code owner February 9, 2022 18:34
tmatsuo
tmatsuo approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, @bcoe might want to add a simple snippet.

bcoe
bcoe approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this looks like a good addition to the docs, a good reason not to add a sample (which I'd originally suggested) is that the methods vary a bit on a client by client basis, and it might confuse a customer if we document a method that's not on the client.

A suggestion, since timeout is one of the more common settings we need to tweak for customers, perhaps we could add an example specifically for timeouts to:

https://github.com/googleapis/gax-nodejs/blob/main/client-libraries.md

@summer-ji-eng summer-ji-eng added the api: automl Issues related to the AutoML API. label Feb 18, 2022
@parthea parthea assigned bcoe and sofisl and unassigned bcoe Apr 1, 2022
@parthea
Copy link
Contributor

parthea commented Apr 1, 2022

Assigning to @sofisl currently on rotation

@parthea parthea assigned SurferJeffAtGoogle and unassigned sofisl Apr 4, 2022
@parthea
Copy link
Contributor

parthea commented Apr 4, 2022

Assigning to @SurferJeffAtGoogle currently on rotation

@bcoe
Copy link
Contributor

bcoe commented Apr 5, 2022

@SurferJeffAtGoogle this will create 150 PRs when merged, so will leave to you whether you choose to merge this week or wait for me to do so during my rotation.

@SurferJeffAtGoogle SurferJeffAtGoogle merged commit e1557e4 into master Apr 7, 2022
@SurferJeffAtGoogle SurferJeffAtGoogle deleted the update_node_readme branch April 7, 2022 16:46
bcoe added a commit that referenced this pull request Apr 7, 2022
@bcoe
Revert "fix: clarify the gax-nodejs usage in README (#1352)"
4993b5c 
This reverts commit e1557e4.
@bcoe bcoe mentioned this pull request Apr 7, 2022
Merged
bcoe added a commit that referenced this pull request Apr 7, 2022
@bcoe
Revert "fix: clarify the gax-nodejs usage in README (#1352)" (#1409)
8a475dc 
This reverts commit e1557e4.
@bcoe bcoe mentioned this pull request Apr 7, 2022
Closed
loferris pushed a commit that referenced this pull request Apr 19, 2022
@summer-ji-eng @bcoe @SurferJeffAtGoogle
fix: clarify the gax-nodejs usage in README (#1352)
75b8c33 
Co-authored-by: Benjamin E. Coe <[email protected]>
Co-authored-by: Jeffrey Rennie <[email protected]>
loferris pushed a commit that referenced this pull request Apr 19, 2022
@bcoe
Revert "fix: clarify the gax-nodejs usage in README (#1352)" (#1409)
212123b 
This reverts commit e1557e4.
parthea added a commit that referenced this pull request Apr 20, 2022
@loferris @parthea
@losalex @tswast @renovate-bot @dandhlee @dependabot @bshaffer @anukaal @tseaver @Neenu1995 @nicain @SurferJeffAtGoogle @busunkim96 @summer-ji-eng @bcoe @sofisl
chore: add function to copy notebook templates (#1420)
b1777ce 
* adding notebook template function

* changing template path

* changing template path

* chore: add googleapis/yoshi-python to CODEOWNERS (#1380)

* chore(python): add E231 to .flake8 ignore list (#1379)

* chore: Enable Size-Label bot in all googleapis Python notebook testing (#1384)

* chore: Enable Size-Label bot in all googleapis Python notebook testing repositories

Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis Python notebook testing repositories

* Remove product 

Remove product since it is by default true

* chore(python): Enable size-label bot (#1383)

* chore: Enable Size-Label bot in all googleapis Python repositories

Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis Python repositories

* Remove product 

Remove product since it is by default true

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore(python): update .pre-commit-config.yaml to use black==22.3.0 (#1378)

Co-authored-by: Tim Swast <[email protected]>

* chore(python): Enable size-label bot (#1385)

* chore: remove dependency on google-api-core (#1372)

* chore(deps): update dependency google-api-core to v2.7.1

* chore: remove dependency on google-api-core

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore(deps): update dependency numpy to v1.22.3 (#1387)

* chore(deps): disable dependency dashboard (#1223)

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore(deps): update dependency pandas to v1.4.1 (#1258)

Co-authored-by: Anthonios Partheniou <[email protected]>

* build(deps): bump ipython (#1336)

Bumps [ipython](https://github.com/ipython/ipython) from 7.0 to 7.16.3.
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](ipython/ipython@7.0.0...7.16.3)

---
updated-dependencies:
- dependency-name: ipython
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: remove use of googleapis-discovery (#1280)

* chore: remove use of googleapis-discovery

* remove constant and method for googleapis-discovery

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore: add classifiers for python 3.7, 3.8 and 3.9 (#1247)

added Support for python 3.7, 3.8, 3.9

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore(python): refactor unit / system test dependency install (#1294)

* chore(python): refactor unit / system test dependency install

Closes #1185.

* chore: use editable installs for local deps

* chore: don't install deps using '-e'

* chore: deprecate 'unit_test_external_dependencies'

* fix: install standard + main unit test deps together

FBO pip resolver.

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore(python_notebooks): update dependency black to v22 (#1396)

* chore(deps): update dependency ipython to v8 (#1397)

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore: Enable Size-Label bot in all googleapis NodeJs repositories (#1382)

* chore: Enable Size-Label bot in all googleapis NodeJs repositories

Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis NodeJs repositories

* Remove product

Remove product since it is by default true

* chore(deps): update dependency setuptools to v61 (#1398)

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore(deps): update dependency org.sonatype.plugins:nexus-staging-maven-plugin to v1.6.12 (#1388)

Co-authored-by: Neenu Shaji <[email protected]>

* ci: update testing pipeline for notebooks (#1345)

* update testing pipeline

* kokoro fix

* fixing linting errors

* Update synthtool/gcp/templates/python_notebooks_testing_pipeline/.cloud-build/execute_changed_notebooks_cli.py

Co-authored-by: Anthonios Partheniou <[email protected]>

* Update synthtool/gcp/templates/python_notebooks_testing_pipeline/.cloud-build/execute_changed_notebooks_cli.py

Co-authored-by: Anthonios Partheniou <[email protected]>

* resolving license year

* removing redundant print statements

* adding developer todos

* reverting protos

* resetting protos to main

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore(deps): update actions/setup-python action to v3 (#1395)

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore: upgrade black in noxfile.py to 22.3.0 (#1377)

* chore: upgrade black to 22.3.0

* update lint also

* run blacken session

* ci: use click>8.0 for blacken/lint sessions

* chore: fix typo

Co-authored-by: nicain <[email protected]>

* rebase error

Co-authored-by: nicain <[email protected]>

* chore(deps): update dependency pandas to v1.4.2 (#1400)

* chore(deps): update dependency setuptools to v61.3.1 (#1399)

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore(deps): update dependency nbqa to v1.3.1 (#1391)

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore(deps): update dependency protobuf to v3.19.4 (#1389)

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore(deps): update dependency protobuf to v3.20.0 (#1403)

* chore(deps): update dependency setuptools to v62 (#1406)

* chore(python): Use python 3.10.4 base image for post processor (#1405)

* chore(deps): update actions/setup-node action to v3 (#1393)

Co-authored-by: Jeffrey Rennie <[email protected]>

* chore(python): add license header to auto-label.yaml (#1404)

* chore: improve logic to configure release-please for previous major versions (#1408)

* fix: allow version.py files without the library version

* chore: remove obsolete file

* chore: run black

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore: Enable Size-Label bot in all googleapis Java repositories (#1381)

* chore: Enable Size-Label bot in all googleapis Java repositories

Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis Java repositories

* Remove product 

Remove product since it is by default true

* add license header

Co-authored-by: Neenu Shaji <[email protected]>

* chore(deps): update actions/checkout action to v3 (#1392)

Co-authored-by: Jeffrey Rennie <[email protected]>

* chore: run tests with Python 3.10 (#1407)

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore(deps): update dependency python to v3.10.4 (#1386)

Co-authored-by: Anthonios Partheniou <[email protected]>
Co-authored-by: Jeffrey Rennie <[email protected]>

* fix: clarify the gax-nodejs usage in README (#1352)

Co-authored-by: Benjamin E. Coe <[email protected]>
Co-authored-by: Jeffrey Rennie <[email protected]>

* Revert "fix: clarify the gax-nodejs usage in README (#1352)" (#1409)

This reverts commit e1557e4.

* chore(deps): update dependency pyupgrade to v2.32.0 (#1412)

* chore(deps): update dependency nbconvert to v6.5.0 (#1414)

* build: make ci testing conditional on engines field in package.json, move configs to Node 12 (#1418)

* build: make ci testing conditional on engines field in package.json, move configs to Node 12

Co-authored-by: Benjamin E. Coe <[email protected]>

* build: sdd srs yaml file (#1419)

* build: add sync-repo-settings and change branch protection

* update names for template

* adding type annotation

Co-authored-by: Anthonios Partheniou <[email protected]>
Co-authored-by: losalex <[email protected]>
Co-authored-by: Tim Swast <[email protected]>
Co-authored-by: WhiteSource Renovate <[email protected]>
Co-authored-by: Dan Lee <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brent Shaffer <[email protected]>
Co-authored-by: Anurag Kumar <[email protected]>
Co-authored-by: Tres Seaver <[email protected]>
Co-authored-by: Neenu Shaji <[email protected]>
Co-authored-by: nicain <[email protected]>
Co-authored-by: Jeffrey Rennie <[email protected]>
Co-authored-by: Bu Sun Kim <[email protected]>
Co-authored-by: Summer Ji <[email protected]>
Co-authored-by: Benjamin E. Coe <[email protected]>
Co-authored-by: sofisl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@tmatsuo tmatsuo tmatsuo approved these changes

Assignees

@SurferJeffAtGoogle SurferJeffAtGoogle

Labels
api: automl Issues related to the AutoML API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@summer-ji-eng @parthea @bcoe @tmatsuo @SurferJeffAtGoogle @sofisl