Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add Authorization section to Java README template #1161

Merged
merged 3 commits into from
Jul 27, 2021

Conversation

minherz
Copy link
Contributor

@minherz minherz commented Jul 19, 2021

as a part of the PR 582 for java-logging an authorization section is added to the Java README template.

Fixing googleapis/java-logging#570.

@minherz minherz requested a review from a team as a code owner July 19, 2021 09:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 19, 2021
@minherz minherz force-pushed the minherz/add-auth-section branch from 135d220 to 2680c31 Compare July 19, 2021 10:01
@minherz minherz changed the title freat: add Authorization section to Java README template feat: add Authorization section to Java README template Jul 19, 2021
@chingor13 chingor13 requested a review from silvolu July 20, 2021 16:02
@chingor13
Copy link
Contributor

@minherz Thanks for submitting this. Will check with the team that oversees auth.

@silvolu Can you review this proposed addition to every Java library's README? Does this match our suggested best practices?

@minherz minherz force-pushed the minherz/add-auth-section branch from d65d3cc to 018a08f Compare July 27, 2021 10:58
@chingor13 chingor13 changed the title feat: add Authorization section to Java README template chore(docs): add Authorization section to Java README template Jul 27, 2021
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 27, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3d32990 into master Jul 27, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the minherz/add-auth-section branch July 27, 2021 15:28
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants