Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: python 3.9 as the default python version for noxfile.py #1141

Closed
wants to merge 1 commit into from

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jun 26, 2021

#1069 was merged which upgrades the python version in the post processor image from python 3.8 to 3.9. The default version for noxfile.py should also be updated.

@parthea parthea requested a review from busunkim96 June 26, 2021 17:09
@parthea parthea requested a review from a team June 26, 2021 17:09
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2021
@parthea
Copy link
Contributor Author

parthea commented Jun 28, 2021

@busunkim96 Please could you review/approve?

@busunkim96
Copy link
Contributor

I'm curious if this is worth the trouble at this point in time? I know you've moved many repos to the templated noxfile but this will cause issues for any noxfiles that aren't - the noxfile will want to use 3.8 for nox -s blacken while the owlbot postprocessor will only have 3.9.

Perhaps it would be better to move the blackening outside of owlbot.py, so changing this version is not as much of a chore.

@parthea
Copy link
Contributor Author

parthea commented Jun 29, 2021

Superseded by #1144 .

I've added an agenda item to the python client libraries meeting to discuss moving the blacken session outside of owlbot.py

@parthea parthea closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants