Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java templates] build.sh should detect sample-secrets #904

Closed
chingor13 opened this issue Jan 14, 2021 · 0 comments · Fixed by #998
Closed

[java templates] build.sh should detect sample-secrets #904

chingor13 opened this issue Jan 14, 2021 · 0 comments · Fixed by #998
Assignees
@Neenu1995
Labels
lang: java Issues specific to Java. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@chingor13
Copy link
Contributor

Many libraries use secrets from secret manager for samples. We source a file in bash which loads environment variables from a secret file.

Example: https://github.com/googleapis/java-bigquerystorage/blob/031655be10038a25dcd6285166fc3269599df525/.kokoro/build.sh#L81-L84

We should generalize this (look for all -samples-secrets files) so maintainers do not need to customize build.sh and ignore the common templates.
@chingor13 chingor13 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 14, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 14, 2021
@chingor13 chingor13 added the lang: java Issues specific to Java. label Jan 14, 2021
@Neenu1995 Neenu1995 mentioned this issue Mar 24, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 24, 2021
@Neenu1995
chore(java): detect sample-secrets in build.sh (#998)
bb854b6 
Fixes #904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Neenu1995 Neenu1995

Labels
lang: java Issues specific to Java. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(java): detect sample-secrets in build.sh googleapis/synthtool
2 participants
@chingor13 @Neenu1995