Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] OwlBot PostProcessor fails to work with java-grafeas module #1743

Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Jan 11, 2023

On googleapis/google-cloud-java#8956, OwlBot PostProcessor fails to work with java-grafeas module. It failed:

Traceback (most recent call last):
 File "/owlbot/src/fix-poms.py", line 504, in <module>
   main()
 File "/owlbot/src/fix-poms.py", line 472, in main
   update_parent_pom("pom.xml", modules)
 File "/owlbot/src/fix-poms.py", line 174, in update_parent_pom
   m.text for i, m in enumerate(existing) if m.text not in module_names
TypeError: 'NoneType' object is not iterable

https://pantheon.corp.google.com/cloud-build/builds;region=global/0cf25338-9826-4fda-abcf-dfa5592b5223;step=5?project=repo-automation-bots

I will work on fixing it.

CC: @JoeWang1127

How to reproduce issue locally

cd google-cloud-java; git fetch
git checkout -b java-grafeas_postprocessor origin/main 
mkdir -p owl-bot-staging/java-grafeas
docker run --rm --user "$(id -u):$(id -g)"         -v "$(pwd):/workspace"   -w /workspace         --env HOME=/tmp         gcr.io/cloud-devrel-public-resources/owlbot-java
suztomo added a commit to suztomo/synthtool that referenced this issue Jan 11, 2023
suztomo added a commit to suztomo/synthtool that referenced this issue Jan 11, 2023
suztomo added a commit to suztomo/synthtool that referenced this issue Jan 11, 2023
@suztomo
Copy link
Member Author

suztomo commented Jan 11, 2023

Why java-grafeas was touched by the pull request googleapis/google-cloud-java#8956?

It's because the files were indeed modified by the change.

~/googleapis-gen $ git show 916424c97215b12211037b5057b833447d073bbd --name-status |grep grafeas
M	grafeas/v1/google-cloud-grafeas-v1-java/gapic-google-cloud-grafeas-v1-java/src/main/java/io/grafeas/v1/GrafeasSettings.java
M	grafeas/v1/google-cloud-grafeas-v1-java/gapic-google-cloud-grafeas-v1-java/src/main/java/io/grafeas/v1/stub/GrafeasStubSettings.java
M	grafeas/v1/google-cloud-grafeas-v1-java/samples/snippets/generated/io/grafeas/v1/grafeassettings/getoccurrence/SyncGetOccurrence.java
M	grafeas/v1/google-cloud-grafeas-v1-java/samples/snippets/generated/io/grafeas/v1/stub/grafeasstubsettings/getoccurrence/SyncGetOccurrence.java

@SurferJeffAtGoogle SurferJeffAtGoogle added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 13, 2023
suztomo added a commit that referenced this issue Jan 19, 2023
gcf-owl-bot bot added a commit to googleapis/google-auth-library-java that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/google-api-java-client that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/java-accessapproval that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/java-artifact-registry that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/google-http-java-client that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/google-oauth-java-client that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/java-accesscontextmanager that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/java-api-gateway that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/java-analytics-data that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/java-errorreporting that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/java-recommendations-ai that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/java-speech that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/java-scheduler that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/java-vision that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/java-workflows that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
gcf-owl-bot bot added a commit to googleapis/java-tasks that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
Neenu1995 pushed a commit to googleapis/java-bigquerystorage that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
alicejli pushed a commit to googleapis/java-shared-dependencies that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
gcf-owl-bot bot added a commit to googleapis/java-gcloud-maven-plugin that referenced this issue Jan 19, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
alicejli added a commit to googleapis/java-core that referenced this issue Jan 20, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Alice <[email protected]>
kolea2 pushed a commit to googleapis/java-bigtable that referenced this issue Jan 20, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
tom-andersen pushed a commit to googleapis/java-firestore that referenced this issue Jan 20, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
losalex pushed a commit to googleapis/java-logging that referenced this issue Jan 21, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
losalex pushed a commit to googleapis/java-logging-logback that referenced this issue Jan 21, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
tom-andersen pushed a commit to googleapis/java-firestore that referenced this issue Jan 23, 2023
* fix(java): skip fixing poms for special modules (#1744)

fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Neenu1995 pushed a commit to googleapis/java-bigquery that referenced this issue Jan 23, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
alicejli pushed a commit to googleapis/java-datastore that referenced this issue Jan 23, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: kolea2 <[email protected]>
rajatbhatta pushed a commit to googleapis/java-spanner-jdbc that referenced this issue Jan 24, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
losalex added a commit to googleapis/java-logging-servlet-initializer that referenced this issue Jan 24, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: losalex <[email protected]>
suztomo pushed a commit to googleapis/google-cloud-java that referenced this issue Feb 1, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo pushed a commit to googleapis/google-cloud-java that referenced this issue Feb 1, 2023
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Alice <[email protected]>
cherylEnkidu pushed a commit to googleapis/java-firestore that referenced this issue Dec 11, 2023
* fix(java): skip fixing poms for special modules (#1744)

fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment