Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content-Range header values are not validated and enforced #685

Open
BenWhitehead opened this issue Oct 10, 2024 · 0 comments
Open

Content-Range header values are not validated and enforced #685

BenWhitehead opened this issue Oct 10, 2024 · 0 comments
Assignees
@cojenco
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@BenWhitehead
Copy link
Contributor

Environment details

  • testbench version 0.45.0

Steps to reproduce

  1. Retry conformance test http-7-[return-503-after-256K]-storage.objects.insert-50
  2. Full http log: https://gist.github.com/BenWhitehead/ae8a02958ff22e1e238057fed3732a15#file-http-log-L104
  3. Notice on like 104 Content-Range: bytes 262144-786431/524288, the end of that range is larger than the specified total number of bytes.
  4. Originally discovered while investigating Core: Seeing unexpected exception during upload to GCS with Java client java-storage#2770
@BenWhitehead BenWhitehead added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 10, 2024
@BenWhitehead BenWhitehead mentioned this issue Oct 10, 2024
Merged
@cojenco cojenco self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cojenco cojenco

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenWhitehead @cojenco