Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for invocation-id to testbench #486

Open
tritone opened this issue Apr 12, 2023 · 0 comments
Open

Add checks for invocation-id to testbench #486

tritone opened this issue Apr 12, 2023 · 0 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tritone
Copy link
Contributor

tritone commented Apr 12, 2023

@saranshdhingra suggested that it would be helpful to add an option to check correctness of the x-goog-api-client header in the retry test support in the testbench.

This might include the following:

  1. Check that gccl-invocation-id is the same for all retries of a given request
  2. [if applicable] Check that gccl-attempt-count starts at 1 and gets incremented for each retry.

We could also add a check for x-goog-gcs-idempotency-token when implemented.

This check could be enabled by a data field or query param to the retry_test POST endpoint.

@tritone tritone added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant