[draft][5/5]Implement default unary rpc method's sample code #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summer-ji-eng
requested review from
miraleung and
xiaozhenliu-gg5
as code owners
product-auto-label
bot
added
the
samples
google-cla
bot
added
the
cla: yes
miraleung
reviewed
Nov 19, 2020
| .setValueExpr(requestBuildExpr) | ||
| .build(); | ||
| } | ||
|
|
||
| private static Expr assignMethodArgumentWithDefaultValue( |
There was a problem hiding this comment.
Can we refactor this so that we use the variable expr throughout (like one would do with Java programming) instead of recreating it several times?
miraleung
suggested changes
Nov 19, 2020
|
|
||
| if (method.isPaged()) { | ||
| // For loop on invoke client method's iterator with comment. | ||
| // e.g. for (EchoClient echoClient : echoClient.PagedExpand(request).iterateAll()) {//..} |
There was a problem hiding this comment.
This line looks off, I'm not sure that iterateAll on that method would return a list of echoClients.
summer-ji-eng
changed the title
|
refactor in #594 |
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## [2.5.0](https://www.github.com/googleapis/java-shared-dependencies/compare/2.4.0...v2.5.0) (2021-11-12) ### Features * next release from main branch is 2.5.0 ([#510](https://www.github.com/googleapis/java-shared-dependencies/issues/510)) ([011be46](https://www.github.com/googleapis/java-shared-dependencies/commit/011be46db0ac3e1dfed31f078679a615757c4f55)) ### Bug Fixes * dependencies.sh to work with Java 17 ([#516](https://www.github.com/googleapis/java-shared-dependencies/issues/516)) ([b9c4b23](https://www.github.com/googleapis/java-shared-dependencies/commit/b9c4b23e5fdb5715d162057a43df5cbacac94acc)) ### Dependencies * update dependency com.google.api:api-common to v2.1.0 ([#508](https://www.github.com/googleapis/java-shared-dependencies/issues/508)) ([497ebf7](https://www.github.com/googleapis/java-shared-dependencies/commit/497ebf75e357688574fd9e9475b03ecc5bcbb723)) * update dependency com.google.auth:google-auth-library-bom to v1.2.2 ([#506](https://www.github.com/googleapis/java-shared-dependencies/issues/506)) ([b26fe14](https://www.github.com/googleapis/java-shared-dependencies/commit/b26fe140c251800090416a664538bd03affec264)) * update dependency com.google.auth:google-auth-library-bom to v1.3.0 ([#524](https://www.github.com/googleapis/java-shared-dependencies/issues/524)) ([615f0a9](https://www.github.com/googleapis/java-shared-dependencies/commit/615f0a9985f24a01c998583b0610a7df67421baf)) * update dependency com.google.code.gson:gson to v2.8.9 ([#509](https://www.github.com/googleapis/java-shared-dependencies/issues/509)) ([6d3efe9](https://www.github.com/googleapis/java-shared-dependencies/commit/6d3efe94a2ef062d5e7012a85c1b654d547f8a24)) * update dependency com.google.errorprone:error_prone_annotations to v2.10.0 ([#512](https://www.github.com/googleapis/java-shared-dependencies/issues/512)) ([ce4e329](https://www.github.com/googleapis/java-shared-dependencies/commit/ce4e3296f4cfe3df6dc94f8c067a2d609820ec88)) * update dependency com.google.protobuf:protobuf-bom to v3.19.1 ([#505](https://www.github.com/googleapis/java-shared-dependencies/issues/505)) ([59dc916](https://www.github.com/googleapis/java-shared-dependencies/commit/59dc916ba22ff2f5c59fe58631315030c86e9b77)) * update dependency io.grpc:grpc-bom to v1.42.1 ([#513](https://www.github.com/googleapis/java-shared-dependencies/issues/513)) ([ddeaf56](https://www.github.com/googleapis/java-shared-dependencies/commit/ddeaf56710b6bf89d14291491c05f97d1c230031)) * update dependency org.checkerframework:checker-qual to v3.19.0 ([#501](https://www.github.com/googleapis/java-shared-dependencies/issues/501)) ([8729670](https://www.github.com/googleapis/java-shared-dependencies/commit/87296708dcdcc5f35dc9b6ce5bfc5eba9cb54bbb)) * update dependency org.threeten:threetenbp to v1.5.2 ([#514](https://www.github.com/googleapis/java-shared-dependencies/issues/514)) ([34be959](https://www.github.com/googleapis/java-shared-dependencies/commit/34be9594cecb05cfec92bf44ce4695aa3c5cc68b)) * update gax.version to v2.7.0 ([#515](https://www.github.com/googleapis/java-shared-dependencies/issues/515)) ([2d288b4](https://www.github.com/googleapis/java-shared-dependencies/commit/2d288b49178e9809bfc314b053f9cedf8cf33fef)) * update google.core.version to v2.3.0 ([#530](https://www.github.com/googleapis/java-shared-dependencies/issues/530)) ([1d201fe](https://www.github.com/googleapis/java-shared-dependencies/commit/1d201fe452303f4ba31c23361cd1917b2d63e8a6)) * update iam.version to v1.1.7 ([#504](https://www.github.com/googleapis/java-shared-dependencies/issues/504)) ([ec3f58c](https://www.github.com/googleapis/java-shared-dependencies/commit/ec3f58ce7761c257c2eb12ba022a1e2dda8e4c05)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [2.0.4](https://www.github.com/googleapis/java-core/compare/v2.0.3...v2.0.4) (2021-08-11) ### Dependencies * update dependency com.google.api:api-common to v2.0.1 ([#516](https://www.github.com/googleapis/java-core/issues/516)) ([0d08b09](https://www.github.com/googleapis/java-core/commit/0d08b09112f190f4f008d811e9f242cc2d928245)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default method generated from here
There are 3 kinds sample code for default unary rpc: