Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: Add experimental S2A integration in client libraries grpc transport" #3400

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Nov 27, 2024

Reverts #3326

Context: #3326 (comment)

s2a-gRPC is an Experimental library and shouldn't be added until it's stabilized.

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Nov 27, 2024
@lqiu96 lqiu96 requested a review from blakeli0 November 27, 2024 20:56
Copy link

@lqiu96
Copy link
Contributor Author

lqiu96 commented Nov 27, 2024

CC: @rmehta19

This is the revert PR

@lqiu96 lqiu96 marked this pull request as ready for review November 27, 2024 20:56
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rmehta19
Copy link
Contributor

rmehta19 commented Dec 2, 2024

CC: @rmehta19

This is the revert PR

SG. We will re-open once S2A is de-experimentalized in gRPC.

@lqiu96 lqiu96 merged commit 254e9ff into main Dec 2, 2024
49 checks passed
@lqiu96 lqiu96 deleted the revert-3326-grpc-channel-using-s2a branch December 2, 2024 17:46
lqiu96 added a commit that referenced this pull request Dec 3, 2024
…pc transport" (#3400)

Reverts #3326

Context:
#3326 (comment)

s2a-gRPC is an Experimental library and shouldn't be added until it's
stabilized.
lqiu96 added a commit that referenced this pull request Dec 3, 2024
…pc transport" (#3400)

Reverts #3326

Context:
#3326 (comment)

s2a-gRPC is an Experimental library and shouldn't be added until it's
stabilized.
rmehta19 added a commit to rmehta19/sdk-platform-java that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants