Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: explicitly specify maven central location for renovate-bot version lookups #3374

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Nov 14, 2024

From #3372, the files .cloudbuild/directories aren't getting updated to use the latest java-shared-config version. From the renovate logs, there appears to be a difference in the registry urls used when looking up versions from maven central.

Registry used when an update to the latest version is successfully made to 1.12.0:

     {
        "datasource": "maven",
        "deps": [
          {
            "currentValue": "1.11.3",
            "currentVersion": "1.11.3",
            "datasource": "maven",
            "depName": "com.google.cloud:google-cloud-shared-config",
            "depType": "parent-root",
            "fileReplacePosition": 702,
            "fixedVersion": "1.11.3",
            "isSingleVersion": true,
            "packageName": "com.google.cloud:google-cloud-shared-config",
            "packageScope": "com.google.cloud",
            "registryUrls": [
              "https://maven-central.storage-download.googleapis.com/maven2/",
              "https://repo.maven.apache.org/maven2"
            ],
            "sourceUrl": "https://github.com/googleapis/java-shared-config",
            "versioning": "maven",
            "warnings": [],
            "updates": [
              {
                "bucket": "non-major",
                "newVersion": "1.12.0",
                "newValue": "1.12.0",
                "releaseTimestamp": "2024-11-13T20:18:15.000Z",
                "newVersionAgeInDays": 0,
                "registryUrl": "https://maven-central.storage-download.googleapis.com/maven2",
                "newMajor": 1,
                "newMinor": 12,
                "newPatch": 0,
                "updateType": "minor",
                "branchName": "renovate/com.google.cloud-google-cloud-shared-config-1.x"
              }
            ]
          },

For .cloudbuild/ files, the registryUrl defaults to https://repo.maven.apache.org/maven2:

      {
        "datasourceTemplate": "maven",
        "depNameTemplate": "com.google.cloud:google-cloud-shared-config",
        "deps": [
          {
            "currentValue": "1.11.3",
            "currentVersion": "1.11.3",
            "currentVersionAgeInDays": 43,
            "currentVersionTimestamp": "2024-10-01T21:54:00.000Z",
            "datasource": "maven",
            "depName": "com.google.cloud:google-cloud-shared-config",
            "fixedVersion": "1.11.3",
            "packageName": "com.google.cloud:google-cloud-shared-config",
            "packageScope": "com.google.cloud",
            "registryUrl": "https://repo.maven.apache.org/maven2",
            "replaceString": "  _JAVA_SHARED_CONFIG_VERSION: '1.11.3'",
            "sourceUrl": "https://github.com/googleapis/java-shared-config",
            "versioning": "maven",
            "warnings": [],
            "updates": []
          }
        ],
        "matchStrings": [
          "  _JAVA_SHARED_CONFIG_VERSION: '(?<currentValue>.+?)'"
        ],
        "packageFile": ".cloudbuild/graalvm/cloudbuild-test-b-downstream-kmsinventory.yaml"
      },

Explicitly specifying registryUrl to https://repo1.maven.org/maven2 worked in https://github.com/mpeddada1/forking-renovate-repro

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 14, 2024
@mpeddada1 mpeddada1 changed the title chore: explicitly specify maven central location for version lookups chore: explicitly specify maven central location for renovate-bot version lookups Nov 14, 2024
Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mpeddada1 mpeddada1 merged commit b20624c into main Nov 14, 2024
52 of 56 checks passed
@mpeddada1 mpeddada1 deleted the renovate-latest-version branch November 14, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants