chore: randomize temp output directory #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeWang1127
changed the title
blakeli0
reviewed
Nov 7, 2024
| @@ -62,7 +62,7 @@ ENV HOME=/home | |||
| ENV OS_ARCHITECTURE="linux-x86_64" | |||
|
|
|||
| # install OS tools | |||
| RUN apk update && apk add unzip curl rsync openjdk11 jq bash nodejs npm git | |||
| RUN apk update && apk add unzip curl rsync openjdk11 jq bash nodejs npm git uuidgen | |||
There was a problem hiding this comment.
Is there anyway to generate a random String without a new dependency? Every new dependency is subject to vulnerabilities.
There was a problem hiding this comment.
Took sometime but I found $RANDOM should be sufficient.
blakeli0
approved these changes
Nov 7, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
$RANDOM(a shell variable that generates a random integer between 0 and 32767) to randomize temp output directory to support parallel generation.