Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [wip] threeten deprecation for java-core #2756

Closed
wants to merge 107 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
107 commits
Select commit Hold shift + click to select a range
212dcfa
chore: initial conversion to java.time in gax production classes
diegomarquezp Jul 18, 2023
62ae4ef
chore: initial conversion to java.time in gax test classes
diegomarquezp Jul 20, 2023
484fd74
chore: use java.time conversion util
diegomarquezp Jul 20, 2023
455b61b
chore: fmt
diegomarquezp Jul 20, 2023
c5eee47
chore: restore mistake in search/replace
diegomarquezp Jul 20, 2023
ef83e0d
chore: ignore java time / threeten differences
diegomarquezp Jul 20, 2023
ee31831
chore: adapt tests
diegomarquezp Jul 20, 2023
f6b3fd7
chore: adapt tests
diegomarquezp Jul 20, 2023
b50b585
Merge branch 'threeten-deprecation-gax' into threeten-deprecation
diegomarquezp Jul 20, 2023
521c8fb
chore: fix expected output using Duration in tests
diegomarquezp Jul 20, 2023
63b882d
chore: fix clirr in other projects
diegomarquezp Jul 20, 2023
774139a
chore: internal usage of java.time in gax
diegomarquezp Jul 26, 2023
0be22ab
chore: adapt builder of `retrying`
diegomarquezp Jul 26, 2023
03a9f65
chore: adapt builders in `gax`
diegomarquezp Jul 27, 2023
523d100
chore: adapt builders in `gax-grpc`
diegomarquezp Jul 27, 2023
43f3077
chore: adapt builders in `gax-httpjson`
diegomarquezp Jul 27, 2023
d4d1428
feat: Introduce @ObsoleteApi
blakeli0 Jul 27, 2023
e261058
chore: format
blakeli0 Jul 27, 2023
490b214
Update api-common-java/src/main/java/com/google/api/core/ObsoleteApi.…
blakeli0 Jul 27, 2023
a1a0136
Update api-common-java/src/main/java/com/google/api/core/ObsoleteApi.…
blakeli0 Jul 27, 2023
8fda898
chore: format
blakeli0 Jul 27, 2023
7879446
chore: Rename value to description.
blakeli0 Jul 27, 2023
5e2c20e
doc: Add a blurb in README.md
blakeli0 Jul 28, 2023
3945a98
doc: Update wording.
blakeli0 Jul 29, 2023
5e9c638
doc: Update wording.
blakeli0 Jul 31, 2023
0b5d5e6
doc: Update wording.
blakeli0 Jul 31, 2023
2e07a48
chore: rename description to value.
blakeli0 Jul 31, 2023
e6c20b7
chore: adapt builders in `google-cloud-core`
diegomarquezp Jul 27, 2023
d7b0cf3
chore: format
diegomarquezp Aug 1, 2023
5cf1289
chore: fix tests in gax/gax
diegomarquezp Aug 1, 2023
44b45d3
Merge remote-tracking branch 'origin/add-obsolete-api' into threeten-…
diegomarquezp Aug 1, 2023
8e221c1
chore: add @ObsoleteApi annotation
diegomarquezp Aug 1, 2023
667f2da
chore: revert changes in gapic-generator-java
diegomarquezp Aug 1, 2023
6113cea
chore: changes in `Instant`
diegomarquezp Aug 1, 2023
9992618
chore: use java.time methods on builders
diegomarquezp Aug 3, 2023
e8a871b
chore: restore `RetrySettingsComposer`
diegomarquezp Aug 3, 2023
fbad4ee
Merge remote-tracking branch 'origin/main' into threeten-deprecation
diegomarquezp Aug 9, 2023
751ba06
Merge remote-tracking branch 'origin/main' into threeten-deprecation
diegomarquezp Aug 23, 2023
e20f974
chore: use local repository for api-common
diegomarquezp Aug 25, 2023
f05f2ef
chore: use local repository
diegomarquezp Aug 28, 2023
1cf298c
Merge remote-tracking branch 'origin/main' into threeten-deprecation
diegomarquezp Oct 25, 2023
4703dcd
format source
diegomarquezp Oct 25, 2023
4635dd5
add test for retry settings propagation
diegomarquezp Oct 25, 2023
7774eb0
restore bazel configurations
diegomarquezp Oct 25, 2023
63261fa
rename time objects test
diegomarquezp Oct 25, 2023
ba456a1
add generic test for time modifier methods
diegomarquezp Oct 25, 2023
2330496
Merge remote-tracking branch 'origin/main' into threeten-deprecation
diegomarquezp May 3, 2024
23c9ac4
Merge branch 'main' into threeten-deprecation
diegomarquezp May 3, 2024
6920222
post-merge fixes
diegomarquezp May 3, 2024
0c8ac5d
add tests for GrpcCallContext
diegomarquezp May 4, 2024
0c8cfb7
add tests for InstantiatingGrpcChannelProvider
diegomarquezp May 4, 2024
f9750ce
add HttpJsonCallContext tests
diegomarquezp May 5, 2024
351f829
modify tests for GrpcCallContext
diegomarquezp May 5, 2024
1be5153
modify InstantiatingGrpcChannelProvider test
diegomarquezp May 5, 2024
f84b521
add tests for HttpJsonCallOptions
diegomarquezp May 5, 2024
31ab5e0
rename to testDurationMethod()
diegomarquezp May 5, 2024
8fc424d
reformat
diegomarquezp May 5, 2024
c3bc83f
add annotation based test for autovalue classes
diegomarquezp May 6, 2024
16fa545
add reflection test for httpjson
diegomarquezp May 6, 2024
4fd48d4
adapt tests of ThresholdBatcher
diegomarquezp May 6, 2024
5dca441
add test for RetrySettings
diegomarquezp May 6, 2024
a58f1bf
use custom annotation for autovalues with default test values
diegomarquezp May 6, 2024
fc2ee3b
Revert "use custom annotation for autovalues with default test values"
diegomarquezp May 6, 2024
6576921
Revert "add test for RetrySettings"
diegomarquezp May 6, 2024
aa11c88
Revert "adapt tests of ThresholdBatcher"
diegomarquezp May 6, 2024
203960a
Revert "add reflection test for httpjson"
diegomarquezp May 6, 2024
5c07021
Revert "add annotation based test for autovalue classes"
diegomarquezp May 6, 2024
6c15c4c
simplify test helpers
diegomarquezp May 6, 2024
e48decf
add tests for HttpJsonCallOptions
diegomarquezp May 7, 2024
7c8a644
add tests for BatchingSettingsTest
diegomarquezp May 7, 2024
21e4240
add test for ThresholdBatcher
diegomarquezp May 7, 2024
8d96c61
add tests for retry settings
diegomarquezp May 7, 2024
eefff2a
chore: reformat
diegomarquezp May 7, 2024
233ce62
add tests for TimedAttemptSettings
diegomarquezp May 7, 2024
f55cf09
fix HttpJsonClientCall test
diegomarquezp May 8, 2024
6b437c1
add license headers to tests
diegomarquezp May 8, 2024
11043d4
add tests for ClientContext
diegomarquezp May 8, 2024
d3ebac5
add tests for ClientSettings
diegomarquezp May 8, 2024
50b0ffd
add tests for FixedWatchdogProvider
diegomarquezp May 8, 2024
21c03bd
fix internal java.time methods in WatchDog related classes
diegomarquezp May 8, 2024
16933f0
add tests for ServerStreamingCallSettings
diegomarquezp May 8, 2024
33a42bd
add tests for StubSettings
diegomarquezp May 8, 2024
bca5067
add test for UnaryCallSettings
diegomarquezp May 8, 2024
c1b91ee
reformat settings test
diegomarquezp May 8, 2024
173dc2e
add tests in tracing
diegomarquezp May 8, 2024
c8dc5f0
Merge branch 'main' into threeten-deprecation
diegomarquezp May 8, 2024
6abced3
remove unnecessary mocks
diegomarquezp May 8, 2024
31792f7
add license for metrics test utils
diegomarquezp May 8, 2024
a67cca5
add clirr ignore for api tracer
diegomarquezp May 8, 2024
a87d2b8
rename overloaded setters in ApiContext
diegomarquezp May 8, 2024
3b3d45a
rename overload method in InstantiatingGrpcChannelProvider
diegomarquezp May 8, 2024
eea294e
fix obsolete api annotations in apicallcontext
diegomarquezp May 8, 2024
48cd5e9
rename overload of HttpJsonCallOptions
diegomarquezp May 8, 2024
060c1fa
rename overload of BatchingSettings
diegomarquezp May 8, 2024
67000c7
modify overload of ThresholdBatcher
diegomarquezp May 8, 2024
9266ad0
fix wrong getter name in exp retry algo
diegomarquezp May 8, 2024
4ee554f
modify overloads in RetrySettings
diegomarquezp May 8, 2024
75668a5
modify overloads in TimedAttemptSettings
diegomarquezp May 8, 2024
964625f
modify overloads of ClientContext
diegomarquezp May 8, 2024
1c0df23
modify overloads in ClientSettings
diegomarquezp May 8, 2024
53d2131
modify overloads for watchdogs
diegomarquezp May 8, 2024
587f060
modify overloads of ServerStreamingCallSettings
diegomarquezp May 8, 2024
427d295
modify overloads of StubSettings
diegomarquezp May 9, 2024
9f51822
modify overloads for UnaryCallSettings
diegomarquezp May 9, 2024
2a4949b
modify overloads in ApiTracer
diegomarquezp May 9, 2024
60a43dd
reformat
diegomarquezp May 9, 2024
76baf1e
update from main
diegomarquezp May 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix obsolete api annotations in apicallcontext
diegomarquezp committed May 8, 2024
commit eea294ea417d045daf70be9c8eee0997445141b6
Original file line number Diff line number Diff line change
@@ -236,7 +236,7 @@ public GrpcCallContext withEndpointContext(EndpointContext endpointContext) {
* org.threeten.bp.Duration}
*/
@Override
@ObsoleteApi("Use withTimeout(java.time.Duration) instead")
@ObsoleteApi("Use withTimeoutDuration(java.time.Duration) instead")
public GrpcCallContext withTimeout(@Nullable org.threeten.bp.Duration timeout) {
return withTimeoutDuration(toJavaTimeDuration(timeout));
}
@@ -286,7 +286,7 @@ public java.time.Duration getTimeoutDuration() {
* org.threeten.bp.Duration}
*/
@Override
@ObsoleteApi("Use withStreamWaitTimeout(java.time.Duration) instead")
@ObsoleteApi("Use withStreamWaitTimeoutDuration(java.time.Duration) instead")
public GrpcCallContext withStreamWaitTimeout(
@Nullable org.threeten.bp.Duration streamWaitTimeout) {
return withStreamWaitTimeoutDuration(toJavaTimeDuration(streamWaitTimeout));
@@ -323,7 +323,7 @@ public GrpcCallContext withStreamWaitTimeoutDuration(
* @return
*/
@Override
@ObsoleteApi("Use withStreamIdleTimeout(java.time.Duration) instead")
@ObsoleteApi("Use withStreamIdleTimeoutDuration(java.time.Duration) instead")
public GrpcCallContext withStreamIdleTimeout(
@Nullable org.threeten.bp.Duration streamIdleTimeout) {
return withStreamIdleTimeoutDuration(toJavaTimeDuration(streamIdleTimeout));
Original file line number Diff line number Diff line change
@@ -259,7 +259,7 @@ public HttpJsonCallContext withTransportChannel(TransportChannel inputChannel) {
* org.threeten.bp.Duration}
*/
@Override
@ObsoleteApi("Use withTimeout(java.time.Duration) instead")
@ObsoleteApi("Use withTimeoutDuration(java.time.Duration) instead")
public HttpJsonCallContext withTimeout(org.threeten.bp.Duration timeout) {
return withTimeoutDuration(toJavaTimeDuration(timeout));
}
@@ -326,7 +326,7 @@ public java.time.Duration getTimeoutDuration() {
* org.threeten.bp.Duration}
*/
@Override
@ObsoleteApi("Use withStreamWaitTimeout(java.time.Duration) instead")
@ObsoleteApi("Use withStreamWaitTimeoutDuration(java.time.Duration) instead")
public HttpJsonCallContext withStreamWaitTimeout(
@Nullable org.threeten.bp.Duration streamWaitTimeout) {
return withStreamWaitTimeoutDuration(toJavaTimeDuration(streamWaitTimeout));
@@ -378,7 +378,7 @@ public java.time.Duration getStreamWaitTimeoutDuration() {
* org.threeten.bp.Duration}
*/
@Override
@ObsoleteApi("Use withStreamIdleTimeout(java.time.Duration) instead")
@ObsoleteApi("Use withStreamIdleTimeoutDuration(java.time.Duration) instead")
public HttpJsonCallContext withStreamIdleTimeout(
@Nullable org.threeten.bp.Duration streamIdleTimeout) {
return withStreamIdleTimeoutDuration(toJavaTimeDuration(streamIdleTimeout));
Original file line number Diff line number Diff line change
@@ -70,7 +70,7 @@ public interface ApiCallContext extends RetryingContext {
* Overload of {@link #withTimeoutDuration(java.time.Duration)} using {@link
* org.threeten.bp.Duration}
*/
@ObsoleteApi("Use withTimeout(java.time.Duration) instead")
@ObsoleteApi("Use withTimeoutDuration(java.time.Duration) instead")
ApiCallContext withTimeout(@Nullable org.threeten.bp.Duration timeout);

/**
@@ -100,7 +100,7 @@ public interface ApiCallContext extends RetryingContext {
* Overload of {@link #withStreamWaitTimeoutDuration(java.time.Duration)} using {@link
* org.threeten.bp.Duration }
*/
@ObsoleteApi("Use withStreamWaitTimeout(java.time.Duration) instead")
@ObsoleteApi("Use withStreamWaitTimeoutDuration(java.time.Duration) instead")
ApiCallContext withStreamWaitTimeout(@Nullable org.threeten.bp.Duration streamWaitTimeout);

/**
@@ -139,7 +139,7 @@ public interface ApiCallContext extends RetryingContext {
* Overload of {@link #withStreamIdleTimeoutDuration(java.time.Duration)} using {@link
* org.threeten.bp.Duration}
*/
@ObsoleteApi("Use withStreamIdleTimeout(java.time.Duration) instead")
@ObsoleteApi("Use withStreamIdleTimeoutDuration(java.time.Duration) instead")
ApiCallContext withStreamIdleTimeout(@Nullable org.threeten.bp.Duration streamIdleTimeout);

/**